From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Peng Hao <peng.hao2@zte.com.cn>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Sasha Levin <sashal@kernel.org>
Subject: [PATCH AUTOSEL 4.4 1/8] ARM: pxa: ssp: unneeded to free devm_ allocated data
Date: Thu, 28 Feb 2019 10:16:05 -0500 [thread overview]
Message-ID: <20190228151614.13022-1-sashal@kernel.org> (raw)
From: Peng Hao <peng.hao2@zte.com.cn>
[ Upstream commit ba16adeb346387eb2d1ada69003588be96f098fa ]
devm_ allocated data will be automatically freed. The free
of devm_ allocated data is invalid.
Fixes: 1c459de1e645 ("ARM: pxa: ssp: use devm_ functions")
Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
[title's prefix changed]
Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
arch/arm/plat-pxa/ssp.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c
index daa1a65f2eb79..6748827c2ec8b 100644
--- a/arch/arm/plat-pxa/ssp.c
+++ b/arch/arm/plat-pxa/ssp.c
@@ -238,8 +238,6 @@ static int pxa_ssp_remove(struct platform_device *pdev)
if (ssp == NULL)
return -ENODEV;
- iounmap(ssp->mmio_base);
-
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
release_mem_region(res->start, resource_size(res));
@@ -249,7 +247,6 @@ static int pxa_ssp_remove(struct platform_device *pdev)
list_del(&ssp->node);
mutex_unlock(&ssp_lock);
- kfree(ssp);
return 0;
}
--
2.19.1
next reply other threads:[~2019-02-28 15:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 15:16 Sasha Levin [this message]
2019-02-28 15:16 ` [PATCH AUTOSEL 4.4 2/8] irqchip/mmp: Only touch the PJ4 IRQ & FIQ bits on enable/disable Sasha Levin
2019-02-28 15:16 ` [PATCH AUTOSEL 4.4 3/8] dmaengine: at_xdmac: Fix wrongfull report of a channel as in use Sasha Levin
2019-02-28 15:16 ` [PATCH AUTOSEL 4.4 4/8] dmaengine: dmatest: Abort test in case of mapping error Sasha Levin
2019-02-28 15:16 ` [PATCH AUTOSEL 4.4 5/8] s390/qeth: fix use-after-free in error path Sasha Levin
2019-02-28 15:16 ` [PATCH AUTOSEL 4.4 6/8] perf symbols: Filter out hidden symbols from labels Sasha Levin
2019-02-28 15:16 ` [PATCH AUTOSEL 4.4 7/8] perf trace: Support multiple "vfs_getname" probes Sasha Levin
2019-02-28 15:16 ` [PATCH AUTOSEL 4.4 8/8] MIPS: Remove function size check in get_frame_info() Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228151614.13022-1-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.hao2@zte.com.cn \
--cc=robert.jarzmik@free.fr \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®