From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3D97C43381 for ; Fri, 1 Mar 2019 14:57:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9BE5820850 for ; Fri, 1 Mar 2019 14:57:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388470AbfCAO53 (ORCPT ); Fri, 1 Mar 2019 09:57:29 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:40205 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728187AbfCAO52 (ORCPT ); Fri, 1 Mar 2019 09:57:28 -0500 Received: from localhost (aaubervilliers-681-1-27-150.w90-88.abo.wanadoo.fr [90.88.147.150]) (Authenticated sender: maxime.ripard@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 2BC3824000C; Fri, 1 Mar 2019 14:57:24 +0000 (UTC) Date: Fri, 1 Mar 2019 15:57:24 +0100 From: Maxime Ripard To: Jagan Teki Cc: Chen-Yu Tsai , Rob Herring , Mark Rutland , Ryan Pannell , Michael Trimarchi , linux-arm-kernel , devicetree , linux-kernel , linux-amarula@amarulasolutions.com Subject: Re: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support Message-ID: <20190301145724.vhvyoqkkxdflg2g7@flea> References: <20190226060240.8783-1-jagan@amarulasolutions.com> <20190226060240.8783-2-jagan@amarulasolutions.com> <20190227153346.dwd3stsbsvf7rwly@flea> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vh4qkh3rchownawq" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --vh4qkh3rchownawq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 27, 2019 at 09:49:23PM +0530, Jagan Teki wrote: > On Wed, Feb 27, 2019 at 9:03 PM Maxime Ripard = wrote: > > > > Hi, > > > > On Tue, Feb 26, 2019 at 11:32:40AM +0530, Jagan Teki wrote: > > > Oceanic A64-5inMFD is a 5 inch Multi function display baseboard > > > designed to mount SoPine SOM. > > > > > > Key features: > > > - Allwinner A64 Cortex-A53 > > > - Mali-400MP2 GPU > > > - AXP803 PMIC > > > - 2GB DDR3 RAM > > > - SD Slot > > > - SPI-NOR flash > > > - EMAC, RTL8211E > > > - MCP2515 CAN > > > - MIPI-DSI > > > - Goodix 911 CTP > > > - USB Host > > > - 12V DC power supply > > > > > > Signed-off-by: Jagan Teki > > > --- > > > arch/arm64/boot/dts/allwinner/Makefile | 1 + > > > .../allwinner/sun50i-a64-oceanic-5inmfd.dts | 46 +++++++++++++++++= ++ > > > 2 files changed, 47 insertions(+) > > > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-= 5inmfd.dts > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot= /dts/allwinner/Makefile > > > index a5fb1eaa8acf..ec39fe856117 100644 > > > --- a/arch/arm64/boot/dts/allwinner/Makefile > > > +++ b/arch/arm64/boot/dts/allwinner/Makefile > > > @@ -2,6 +2,7 @@ > > > dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-a64-amarula-relic.dtb > > > dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-a64-bananapi-m64.dtb sun50i-a64= -bananapi-m64-icn6211.dtb > > > dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-a64-nanopi-a64.dtb > > > +dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-a64-oceanic-5inmfd.dtb > > > dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-a64-olinuxino.dtb > > > dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-a64-orangepi-win.dtb > > > dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-a64-pine64-lts.dtb > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.= dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts > > > new file mode 100644 > > > index 000000000000..d73d1f55acb9 > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts > > > @@ -0,0 +1,46 @@ > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > +/* > > > + * Copyright (C) 2019 Oceanic Systems (UK) Ltd. > > > + * Copyright (C) 2019 Amarula Solutions B.V. > > > + * Author: Jagan Teki > > > + */ > > > + > > > +/dts-v1/; > > > + > > > +#include "sun50i-a64-sopine.dtsi" > > > + > > > +/ { > > > + model =3D "Oceanic A64-5inMFD"; > > > + compatible =3D "oceanic,a64-5inmfd", "allwinner,sun50i-a64"; > > > > The name of the DT is Oceanic 5inMFD, while you call the board > > A64-5inMFD here, which name is the actual name? >=20 > Yes, this is something that we discussed during "Amarula A64-Relic" > naming convention. >=20 > Since these boards are not famous like teres-i we agreed to add vendor > name after sun50i-a64- followed by real board name. >=20 > Here A64 already covered during sun50i-a64- so the dts name simply the > - For the DT name, yeah, we want that pattern. For the compatible and model, we want to use the model name. > > > > > + > > > + aliases { > > > + serial0 =3D &uart0; > > > + }; > > > + > > > + chosen { > > > + stdout-path =3D "serial0:115200n8"; > > > + }; > > > +}; > > > + > > > +&ehci0 { > > > + status =3D "okay"; > > > +}; > > > + > > > +&ohci0 { > > > + status =3D "okay"; > > > +}; > > > + > > > +&uart0 { > > > + pinctrl-names =3D "default"; > > > + pinctrl-0 =3D <&uart0_pb_pins>; > > > + status =3D "okay"; > > > +}; > > > + > > > +&usb_otg { > > > + dr_mode =3D "host"; > > > + status =3D "okay"; > > > +}; > > > + > > > +&usbphy { > > > + status =3D "okay"; > > > +}; > > > > Is the OTG controller really is only capable of running in host mode? >=20 > Yes, USB on baseboard is similar like sopine-baseboard Ok Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --vh4qkh3rchownawq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXHlIVAAKCRDj7w1vZxhR xTejAP9dyNTkKV5xopYBKm8cgShd8fknffNc0mrFQg6OFOaaTwD7B+sF/OZEessh /5myP1IHEqhqSa5qxS+r+xB8dP40bQo= =ZBXm -----END PGP SIGNATURE----- --vh4qkh3rchownawq--