From: Yifeng Li <tomli@tomli.me>
To: Jiri Kosina <trivial@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org
Cc: Yifeng Li <tomli@tomli.me>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
linux-kernel@vger.kernel.org, Jin Chen <nobijinc@gmail.com>
Subject: [RESEND][PATCH 2/2] staging: sm750fb: trivial Camel Case removal for setDisplayControl().
Date: Mon, 4 Mar 2019 00:55:32 +0800 [thread overview]
Message-ID: <20190303165532.23727-3-tomli@tomli.me> (raw)
In-Reply-To: <20190303165532.23727-1-tomli@tomli.me>
Rename the function setDisplayControl() to set_display_control().
This fixes the following checkpatch.pl warning:
CHECK: Avoid CamelCase: <setDisplayControl>
Suggested-by: Jin Chen <nobijinc@gmail.com>
Signed-off-by: Jin Chen <nobijinc@gmail.com>
[tomli@tomli.me: resent as trivial patch, reworded the commit message]
Signed-off-by: Yifeng Li <tomli@tomli.me>
---
drivers/staging/sm750fb/ddk750_display.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb/ddk750_display.c
index 1273e7d18925..f38051eedb6c 100644
--- a/drivers/staging/sm750fb/ddk750_display.c
+++ b/drivers/staging/sm750fb/ddk750_display.c
@@ -5,7 +5,7 @@
#include "ddk750_power.h"
#include "ddk750_dvi.h"
-static void setDisplayControl(int ctrl, int disp_state)
+static void set_display_control(int ctrl, int disp_state)
{
/* state != 0 means turn on both timing & plane en_bit */
unsigned long reg, val, reserved;
@@ -137,12 +137,12 @@ void ddk750_setLogicalDispOut(enum disp_output output)
if (output & PRI_TP_USAGE) {
/* set primary timing and plane en_bit */
- setDisplayControl(0, (output & PRI_TP_MASK) >> PRI_TP_OFFSET);
+ set_display_control(0, (output & PRI_TP_MASK) >> PRI_TP_OFFSET);
}
if (output & SEC_TP_USAGE) {
/* set secondary timing and plane en_bit*/
- setDisplayControl(1, (output & SEC_TP_MASK) >> SEC_TP_OFFSET);
+ set_display_control(1, (output & SEC_TP_MASK) >> SEC_TP_OFFSET);
}
if (output & PNL_SEQ_USAGE) {
--
2.20.1
next prev parent reply other threads:[~2019-03-03 16:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-03 16:55 [RESEND][PATCH 0/2] staging: sm750fb: trivial style fixes Yifeng Li
2019-03-03 16:55 ` [RESEND][PATCH 1/2] staging: sm750fb: trivial comment indention fix Yifeng Li
2019-03-03 16:55 ` Yifeng Li [this message]
2019-03-07 20:22 ` [RESEND][PATCH 2/2] staging: sm750fb: trivial Camel Case removal for setDisplayControl() Greg Kroah-Hartman
2019-03-20 12:36 ` Dan Carpenter
2019-03-03 17:56 ` [RESEND][PATCH 0/2] staging: sm750fb: trivial style fixes Greg Kroah-Hartman
2019-03-20 5:13 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190303165532.23727-3-tomli@tomli.me \
--to=tomli@tomli.me \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nobijinc@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®