From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org,
Yanjun.Zhu@windriver.com, xiangxia.m.yue@gmail.com,
nicolas.dichtel@6wind.com, dsahern@gmail.com,
christian@brauner.io, lucien.xin@gmail.com,
xiyou.wangcong@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ignore sysctl_devconf_inherit_init_net without SYSCTL
Date: Mon, 04 Mar 2019 13:14:59 -0800 (PST) [thread overview]
Message-ID: <20190304.131459.349979845655858570.davem@davemloft.net> (raw)
In-Reply-To: <20190304203822.2094613-1-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 4 Mar 2019 21:38:03 +0100
> When CONFIG_SYSCTL is turned off, we get a link failure for
> the newly introduced tuning knob.
>
> net/ipv6/addrconf.o: In function `addrconf_init_net':
> addrconf.c:(.text+0x31dc): undefined reference to `sysctl_devconf_inherit_init_net'
>
> Add an IS_ENABLED() check to fall back to the default behavior
> (sysctl_devconf_inherit_init_net=0) here.
>
> Fixes: 856c395cfa63 ("net: introduce a knob to control whether to inherit devconf config")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thanks Arnd.
prev parent reply other threads:[~2019-03-04 21:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 20:38 Arnd Bergmann
2019-03-04 21:00 ` Christian Brauner
2019-03-04 21:07 ` Arnd Bergmann
2019-03-04 21:08 ` Christian Brauner
2019-03-04 21:14 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304.131459.349979845655858570.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Yanjun.Zhu@windriver.com \
--cc=arnd@arndb.de \
--cc=christian@brauner.io \
--cc=dsahern@gmail.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=xiangxia.m.yue@gmail.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®