From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EE27C10F03 for ; Mon, 4 Mar 2019 10:24:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E1FF420823 for ; Mon, 4 Mar 2019 10:24:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=verge.net.au header.i=@verge.net.au header.b="IutLse4u" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726186AbfCDKYb (ORCPT ); Mon, 4 Mar 2019 05:24:31 -0500 Received: from kirsty.vergenet.net ([202.4.237.240]:39262 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726032AbfCDKYa (ORCPT ); Mon, 4 Mar 2019 05:24:30 -0500 Received: from reginn.horms.nl (watermunt.horms.nl [80.127.179.77]) by kirsty.vergenet.net (Postfix) with ESMTPA id CA79A25B74E; Mon, 4 Mar 2019 21:24:25 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=verge.net.au; s=mail; t=1551695066; bh=T4VWP9pUoWbbuL67atuRtOPA0w+w3i3Vld6gseaDoe0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IutLse4uF4sxg3SheIN7qB0rz5LEVdQ07/xnctYgzGGU0p4qtHyvGENCsNpNiWCPZ IoN9F9M0rq+b/JY1qsD+3KanuOXfrqseIS3aRGitja7PKO+QKmioNAqL92F58Xh5br c3SDjEbg25QJwLqftZXTIooabNOMJDy3Mti8ZxkM= Received: by reginn.horms.nl (Postfix, from userid 7100) id 18A9594030D; Mon, 4 Mar 2019 11:24:24 +0100 (CET) Date: Mon, 4 Mar 2019 11:24:24 +0100 From: Simon Horman To: Geert Uytterhoeven Cc: Wen Yang , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Russell King , Linux ARM , Linux Kernel Mailing List , Kukjin Kim , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Michal Simek , Andreas =?utf-8?Q?F=C3=A4rber?= , Manivannan Sadhasivam , Dinh Nguyen , Heiko Stuebner , "open list:ARM/Rockchip SoC..." , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Linus Walleij , avifishman70@gmail.com, tmaimon77@gmail.com, venture@google.com, yuenn@google.com, brendanhiggins@google.com, openbmc@lists.ozlabs.org, Wei Xu , Maxime Ripard , Chen-Yu Tsai , Catalin Marinas , Will Deacon , Magnus Damm , Linux-Renesas , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , linux-imx@nxp.com, wang.yi59@zte.com.cn Subject: Re: [PATCH 08/15] ARM: shmobile: fix a leaked reference by addingmissing of_node_put Message-ID: <20190304102423.bipib6frc6ma2ltv@verge.net.au> References: <1551430616-42014-1-git-send-email-wen.yang99@zte.com.cn> <1551430616-42014-8-git-send-email-wen.yang99@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organisation: Horms Solutions BV User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 01, 2019 at 10:51:27AM +0100, Geert Uytterhoeven wrote: > On Fri, Mar 1, 2019 at 9:57 AM Wen Yang wrote: > > The call to of_get_next_child returns a node pointer with refcount > > incremented thus it must be explicitly decremented after the last > > usage. > > > > Detected by coccinelle with the following warnings: > > ./arch/arm/mach-shmobile/pm-rcar-gen2.c:77:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function. > > ./arch/arm/mach-shmobile/pm-rcar-gen2.c:85:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function. > > ./arch/arm/mach-shmobile/pm-rcar-gen2.c:90:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function. > > > > Signed-off-by: Wen Yang > > Reviewed-by: Geert Uytterhoeven Thanks, applied for v5.2.