From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF6BCC43381 for ; Mon, 4 Mar 2019 21:56:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BBAA720823 for ; Mon, 4 Mar 2019 21:56:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726510AbfCDV44 (ORCPT ); Mon, 4 Mar 2019 16:56:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:53824 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726076AbfCDV44 (ORCPT ); Mon, 4 Mar 2019 16:56:56 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DEF5D206B6; Mon, 4 Mar 2019 21:56:54 +0000 (UTC) Date: Mon, 4 Mar 2019 16:56:53 -0500 From: Steven Rostedt To: Tom Zanussi Cc: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org, Tom Zanussi , Namhyung Kim Subject: Re: [PATCH 2/2] tracing: Use strncpy instead of memcpy for string keys in hist triggers Message-ID: <20190304165653.17699f9f@gandalf.local.home> In-Reply-To: <20190304165000.0ce0fbdd@gandalf.local.home> References: <50c35ae1267d64eee975b8125e151e600071d4dc.1549309756.git.tom.zanussi@linux.intel.com> <20190304165000.0ce0fbdd@gandalf.local.home> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 4 Mar 2019 16:50:00 -0500 Steven Rostedt wrote: > > +++ b/kernel/trace/trace_events_hist.c > > @@ -4695,9 +4695,10 @@ static inline void add_to_key(char *compound_key, void *key, > > /* ensure NULL-termination */ > > if (size > key_field->size - 1) > > size = key_field->size - 1; > > - } > > > > - memcpy(compound_key + key_field->offset, key, size); > > + strncpy(compound_key + key_field->offset, (char *)key, size); > > + } else > > + memcpy(compound_key + key_field->offset, key, size); > > } > > > > Shouldn't we use strncpy() in save_comm() too. Feels safer. Note, if that is changed, it can be another patch. This one is fine as is. I just was looking at other use cases of memcpy() in that file. -- Steve