From: Arnd Bergmann <arnd@arndb.de>
To: Darren Hart <dvhart@infradead.org>, Andy Shevchenko <andy@infradead.org>
Cc: Linus Walleij <linusw@kernel.org>,
Enrico Weigelt <info@metux.net>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-gpio@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] x86: apuv2: fix input dependencies
Date: Mon, 4 Mar 2019 21:19:20 +0100 [thread overview]
Message-ID: <20190304201930.1622839-2-arnd@arndb.de> (raw)
In-Reply-To: <20190304201930.1622839-1-arnd@arndb.de>
We cannot select KEYBOARD_GPIO_POLLED if CONFIG_INPUT or CONFIG_INPUT_KEYBOARD
are disabled:
WARNING: unmet direct dependencies detected for KEYBOARD_GPIO_POLLED
Depends on [n]: !UML && INPUT [=y] && INPUT_KEYBOARD [=n] && GPIOLIB [=y]
Selected by [y]:
- PCENGINES_APU2 [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y]
This could be fixed using either a dependency or a 'select' statement.
I'm chosen 'depends on' here since it is simpler has a lower risk of
introducing circular dependencies.
Fixes: f8eb0235f659 ("x86: pcengines apuv2 gpio/leds/keys platform driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/platform/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 851ea921a58d..4d65d37b0c86 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1305,6 +1305,7 @@ config HUAWEI_WMI
config PCENGINES_APU2
tristate "PC Engines APUv2/3 front button and LEDs driver"
+ depends on INPUT && INPUT_KEYBOARD
select GPIO_AMD_FCH
select KEYBOARD_GPIO_POLLED
select LEDS_GPIO
--
2.20.0
next prev parent reply other threads:[~2019-03-04 20:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 20:19 [PATCH 1/3] x86: apuv2: remove unused variable Arnd Bergmann
2019-03-04 20:19 ` Arnd Bergmann [this message]
2019-03-05 0:18 ` [PATCH 2/3] x86: apuv2: fix input dependencies Enrico Weigelt, metux IT consult
2019-03-05 8:23 ` Arnd Bergmann
2019-03-05 13:50 ` Enrico Weigelt, metux IT consult
2019-03-05 13:56 ` Andy Shevchenko
2019-03-07 0:10 ` Enrico Weigelt, metux IT consult
2019-03-07 7:03 ` Darren Hart
2019-03-05 16:46 ` Arnd Bergmann
2019-03-04 20:19 ` [PATCH 3/3] x86: apuv2: select LEDS_CLASS Arnd Bergmann
2019-03-05 0:03 ` Enrico Weigelt, metux IT consult
2019-03-05 0:09 ` Randy Dunlap
2019-03-08 9:05 ` Linus Walleij
2019-03-05 0:04 ` [PATCH 1/3] x86: apuv2: remove unused variable Enrico Weigelt, metux IT consult
2019-03-05 13:47 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304201930.1622839-2-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=info@metux.net \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®