From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1463C43381 for ; Wed, 6 Mar 2019 11:33:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 90E8F20675 for ; Wed, 6 Mar 2019 11:33:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729253AbfCFLd5 (ORCPT ); Wed, 6 Mar 2019 06:33:57 -0500 Received: from a.mx.secunet.com ([62.96.220.36]:43510 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725783AbfCFLd4 (ORCPT ); Wed, 6 Mar 2019 06:33:56 -0500 Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id 953A420184; Wed, 6 Mar 2019 12:33:54 +0100 (CET) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZQg6QigyqBCq; Wed, 6 Mar 2019 12:33:54 +0100 (CET) Received: from mail-essen-01.secunet.de (mail-essen-01.secunet.de [10.53.40.204]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id 41E152007E; Wed, 6 Mar 2019 12:33:54 +0100 (CET) Received: from gauss2.secunet.de (10.182.7.193) by mail-essen-01.secunet.de (10.53.40.204) with Microsoft SMTP Server id 14.3.439.0; Wed, 6 Mar 2019 12:33:53 +0100 Received: by gauss2.secunet.de (Postfix, from userid 1000) id 8F593318273F; Wed, 6 Mar 2019 12:33:53 +0100 (CET) Date: Wed, 6 Mar 2019 12:33:53 +0100 From: Steffen Klassert To: Su Yanjun CC: , , , Subject: Re: [PATCH v2] net: xfrm: Add '_rcu' tag for rcu protected pointer in netns_xfrm Message-ID: <20190306113353.GC3758@gauss3.secunet.de> References: <1551748754-16895-1-git-send-email-suyj.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1551748754-16895-1-git-send-email-suyj.fnst@cn.fujitsu.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-G-Data-MailSecurity-for-Exchange-State: 0 X-G-Data-MailSecurity-for-Exchange-Error: 0 X-G-Data-MailSecurity-for-Exchange-Sender: 23 X-G-Data-MailSecurity-for-Exchange-Server: d65e63f7-5c15-413f-8f63-c0d707471c93 X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 X-G-Data-MailSecurity-for-Exchange-Guid: 464EDDEC-A539-47D1-A38B-B7532755C714 X-G-Data-MailSecurity-for-Exchange-ProcessedOnRouted: True Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 04, 2019 at 08:19:14PM -0500, Su Yanjun wrote: > For rcu protected pointers, we'd better add '__rcu' for them. > > Once added '__rcu' tag for rcu protected pointer, the sparse tool reports > warnings. > > net/xfrm/xfrm_user.c:1198:39: sparse: expected struct sock *sk > net/xfrm/xfrm_user.c:1198:39: sparse: got struct sock [noderef] *nlsk > [...] > > So introduce a new wrapper function of nlmsg_unicast to handle type > conversions. > > No functional change. While that was true for v1 of that patch, it is not true for this version. This fixes a direct access of a rcu protected socket. So please add a proper 'Fixes' tag.