From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4EAAC10F00 for ; Wed, 6 Mar 2019 23:38:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F13620842 for ; Wed, 6 Mar 2019 23:38:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551915504; bh=a7eZWlQQ7Mm6881MX6dCx/DYzim0+FY4sKnqS7tfm0A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=NuK/ssYIWKZdxh6xyqZ/Kf/54pZOWmoWx/dTu90ZjjtbldiIkcfYAzxPvzzP3D6Hv oiydlE5mDKtcSQplar2BLlXqbTSl4J5TKGQHnsxdjzSTOWdA7+wAD/tdZRKn102wVQ tB+/a0PQkbkiI5FEq4v/5qSNgvGPsFpdhGwndGFQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726241AbfCFXiX (ORCPT ); Wed, 6 Mar 2019 18:38:23 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:33836 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726010AbfCFXiW (ORCPT ); Wed, 6 Mar 2019 18:38:22 -0500 Received: from akpm3.svl.corp.google.com (unknown [104.133.8.65]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id DBE955AB3; Wed, 6 Mar 2019 23:38:20 +0000 (UTC) Date: Wed, 6 Mar 2019 15:38:19 -0800 From: Andrew Morton To: Dominique Martinet Cc: Jiri Kosina , Vlastimil Babka , Linus Torvalds , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-api@vger.kernel.org, Peter Zijlstra , Greg KH , Jann Horn , Andy Lutomirski , Cyril Hrubis , Daniel Gruss , Dave Chinner , Kevin Easton , "Kirill A. Shutemov" , Matthew Wilcox , Tejun Heo Subject: Re: [PATCH 0/3] mincore() and IOCB_NOWAIT adjustments Message-Id: <20190306153819.3510a19ffe510b674a7890ce@linux-foundation.org> In-Reply-To: <20190306233209.GA7753@nautica> References: <20190130124420.1834-1-vbabka@suse.cz> <20190306143547.c686225447822beaf3b6e139@linux-foundation.org> <20190306152337.e06cbc530fbfbcfcfe0dc37c@linux-foundation.org> <20190306233209.GA7753@nautica> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 7 Mar 2019 00:32:09 +0100 Dominique Martinet wrote: > Andrew Morton wrote on Wed, Mar 06, 2019: > > On Wed, 6 Mar 2019 23:48:03 +0100 (CET) Jiri Kosina wrote: > > > > > 3/3 is actually waiting for your decision, see > > > > > > https://lore.kernel.org/lkml/20190212063643.GL15609@dhcp22.suse.cz/ > > > > I pity anyone who tried to understand this code by reading this code. > > Can we please get some careful commentary in there explaining what is > > going on, and why things are thus? > > > > I guess the [3/3] change makes sense, although it's unclear whether > > anyone really needs it? 5.0 was released with 574823bfab8 ("Change > > mincore() to count "mapped" pages rather than "cached" pages") so we'll > > have a release cycle to somewhat determine how much impact 574823bfab8 > > has on users. How about I queue up [3/3] and we reevaluate its > > desirability in a couple of months? > > FWIW, > > 574823bfab8 has been reverted in 30bac164aca750, included in 5.0-rc4, so > the controversial change has only been there from 5.0-rc1 to 5.0-rc3 Ah, OK, thanks, I misread. Linus, do you have thoughts on http://lkml.kernel.org/r/20190130124420.1834-4-vbabka@suse.cz ?