From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86198C43381 for ; Thu, 7 Mar 2019 18:59:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6286A20851 for ; Thu, 7 Mar 2019 18:59:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726683AbfCGS7t (ORCPT ); Thu, 7 Mar 2019 13:59:49 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:53224 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726600AbfCGS7s (ORCPT ); Thu, 7 Mar 2019 13:59:48 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 6E17414B799E4; Thu, 7 Mar 2019 10:59:48 -0800 (PST) Date: Thu, 07 Mar 2019 10:59:48 -0800 (PST) Message-Id: <20190307.105948.1981340598721314500.davem@davemloft.net> To: natechancellor@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: atm: Add another IS_ENABLED(CONFIG_COMPAT) in atm_dev_ioctl From: David Miller In-Reply-To: <20190307181125.7705-1-natechancellor@gmail.com> References: <20190307165741.19870-1-natechancellor@gmail.com> <20190307181125.7705-1-natechancellor@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 07 Mar 2019 10:59:48 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nathan Chancellor Date: Thu, 7 Mar 2019 11:11:26 -0700 > I removed compat's universal assignment to 0, which allows this if > statement to fall through when compat is passed with a value other > than 0. > > Fixes: f9d19a7494e5 ("net: atm: Use IS_ENABLED in atm_dev_ioctl") > Signed-off-by: Nathan Chancellor Applied.