From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Jozsef Kadlecsik" <kadlec@blackhole.kfki.hu>,
"Florian Westphal" <fw@strlen.de>,
"David S. Miller" <davem@davemloft.net>,
"Máté Eckl" <ecklm94@gmail.com>,
"Fernando Fernandez Mancera" <ffmancera@riseup.net>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
alin.nastac@gmail.com
Subject: Re: [PATCH] netfilter: nf_conntrack_sip: fix IPV6 dependency
Date: Fri, 8 Mar 2019 17:04:41 +0100 [thread overview]
Message-ID: <20190308160441.ler2hs44oaozoq7w@salvia> (raw)
In-Reply-To: <20190304204019.2142770-1-arnd@arndb.de>
hi Arnd,
Cc'ing Alin Nastac.
On Mon, Mar 04, 2019 at 09:40:12PM +0100, Arnd Bergmann wrote:
> With CONFIG_IPV6=m and CONFIG_NF_CONNTRACK_SIP=y, we now get a link failure:
>
> net/netfilter/nf_conntrack_sip.o: In function `process_sdp':
> nf_conntrack_sip.c:(.text+0x4344): undefined reference to `ip6_route_output_flags'
I see. We can probably use nf_route() instead.
Or if needed, use struct nf_ipv6_ops for this.
if (v6ops)
ret = v6ops->route_xyz(...);
@Alin: Would you send us a patch to do so to fix a3419ce3356cf1f
netfilter: nf_conntrack_sip: add sip_external_media logic".
This direct dependency with IPv6 is superfluous, it should not happen.
Thanks!
next prev parent reply other threads:[~2019-03-08 16:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 20:40 Arnd Bergmann
2019-03-08 16:04 ` Pablo Neira Ayuso [this message]
2019-03-08 16:21 ` Alin Năstac
2019-06-18 18:09 ` Arnd Bergmann
2019-06-18 18:13 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190308160441.ler2hs44oaozoq7w@salvia \
--to=pablo@netfilter.org \
--cc=alin.nastac@gmail.com \
--cc=arnd@arndb.de \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=ecklm94@gmail.com \
--cc=ffmancera@riseup.net \
--cc=fw@strlen.de \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®