From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FB65C43381 for ; Tue, 12 Mar 2019 07:59:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F728214AE for ; Tue, 12 Mar 2019 07:59:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=umn.edu header.i=@umn.edu header.b="Ch9vuvjy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727178AbfCLH75 (ORCPT ); Tue, 12 Mar 2019 03:59:57 -0400 Received: from mta-p8.oit.umn.edu ([134.84.196.208]:56324 "EHLO mta-p8.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726614AbfCLH75 (ORCPT ); Tue, 12 Mar 2019 03:59:57 -0400 Received: from localhost (unknown [127.0.0.1]) by mta-p8.oit.umn.edu (Postfix) with ESMTP id E7C3CA99 for ; Tue, 12 Mar 2019 07:59:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p8.oit.umn.edu ([127.0.0.1]) by localhost (mta-p8.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uIQRTyV2V7Xu for ; Tue, 12 Mar 2019 02:59:55 -0500 (CDT) Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p8.oit.umn.edu (Postfix) with ESMTPS id B6462AA5 for ; Tue, 12 Mar 2019 02:59:55 -0500 (CDT) Received: by mail-io1-f70.google.com with SMTP id e9so1227481iob.4 for ; Tue, 12 Mar 2019 00:59:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=1nkZcVU0GvUzDc/ZYNTpuRtHlao+2b0Vm1VZH2b1N8U=; b=Ch9vuvjydJ4EhQPIcG7puULxC+JRbV5Chpg2PLSeQh+EyWOBrybWR1/nJNODcDbxaI PQskGTtnLDWIo5/AU/BTCwwMJnVQgJs3ekRvPcMXx9Pp984XlFYGe7ufnX/NcpnSoEor UorOHxgCM15q/CNDL8doF8cO90EcjUkKKvp+pmPW36YpXU7aK0nB1MOgA+u6Z8i4gMZn XjmF4beVRrUNsqrgPHlNdEt3BVcTXDjYdAjqBsVNp7sxXBsHUXYnqQFn5cNQPRmM3rlM snfDcGx7lXb78OO0gkXQ/5Yi3ibqv00LObONxyBOn9Ul81VHh61U4k69iGjjy3XnLsIC EwnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=1nkZcVU0GvUzDc/ZYNTpuRtHlao+2b0Vm1VZH2b1N8U=; b=UAqEP4ibNVfvh7cNQGN74cjljM44UJzRXgphkIe1mQGpjlplEceFDm1vY2VMpP4sFZ feWIa9qJs+GmU97FuQx9FqNv4Ulls3lR0desKGngeR+TfSxWRQYNStZqSyc02lO56Kc3 pQzLKMpjDLiiNt3w7KMTylUWP/Hy/5166ol9UpVNesaI4llgKcI5n94wVb1X3bL5cPPa zzhMt/LHUwbGUmZAWvKd7WFonVaeExiHstTIF3zvPgushXOiV5yK132BmAA2BA8ZKbC2 kcIs/MmiATnG5vkgV7mXXyXucF5gt0sX8NEQ1Ec5cbVRlMkbJ3ZlfvjAOaLG+M0Zuj7e vZpQ== X-Gm-Message-State: APjAAAU+BSORs5IKLXQdQOaf+xz1fT43L9toqM8uzdNv8wv4jS813zBo kJCW8tFY5xPAz930tkkCYNyTbyqd5WQgvDB3HPjqTQYclSkAIDH4cVj0/tIYeVQwN3juu28vfmH U3ybxQq4cZ/BREbLbjGX3EhhbiTHq X-Received: by 2002:a02:4083:: with SMTP id n125mr21568212jaa.63.1552377595298; Tue, 12 Mar 2019 00:59:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqyOfP+9mqD+1XLGDv4RfFO3LOxcYkCR4RoLYjEACGFPQr+ni9W5LMOCuUKOkpHRPxMIwUeagA== X-Received: by 2002:a02:4083:: with SMTP id n125mr21568200jaa.63.1552377595059; Tue, 12 Mar 2019 00:59:55 -0700 (PDT) Received: from bee.dtc.umn.edu (cs-bee-u.cs.umn.edu. [128.101.106.63]) by smtp.gmail.com with ESMTPSA id u12sm3391365iop.77.2019.03.12.00.59.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Mar 2019 00:59:54 -0700 (PDT) From: Kangjie Lu To: kjlu@umn.edu Cc: pakki001@umn.edu, Ping-Ke Shih , Kalle Valo , "David S. Miller" , Larry Finger , Andrew Morton , Ingo Molnar , Randy Dunlap , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: rtl8192c: fix a potential NULL pointer dereference Date: Tue, 12 Mar 2019 02:59:46 -0500 Message-Id: <20190312075948.1569-1-kjlu@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In case dev_alloc_skb fails, the fix safely returns to avoid potential NULL pointer dereference. Signed-off-by: Kangjie Lu --- drivers/net/wireless/realtek/rtlwifi/rtl8192c/fw_common.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/fw_common.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192c/fw_common.c index 18c76990a089..9042fc044c7e 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/fw_common.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192c/fw_common.c @@ -623,6 +623,9 @@ void rtl92c_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, u1rsvdpageloc, 3); skb = dev_alloc_skb(totalpacketlen); + if (!skb) + return; + skb_put_data(skb, &reserved_page_packet, totalpacketlen); if (cmd_send_packet) -- 2.17.1