From: Andrew Morton <akpm@linux-foundation.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Drop -Wdeclaration-after-statement
Date: Tue, 12 Mar 2019 13:53:34 -0700 [thread overview]
Message-ID: <20190312135334.9dca95d348bb6c0fdc869fe9@linux-foundation.org> (raw)
In-Reply-To: <20190312201853.GA9013@avx2>
> > >
> > > It is not good in my opinion to stick to -Wdeclaration-after-statement.
> >
> > Why?
>
> It is useful to have declarations mixed with code.
Am inclined to agree. Maybe.
> Once kernel will switch to C99 or C11 it _will_ be used to the point of
> requiring it on the coding style level. The superstition of declaring
> everything in the beginning of a function will fall, so might as well
> start earlier.
Sure, it's a matter of kernel coding conventions.
But this isn't the way to get those changed! The process for making such
changes involves large numbers of people arguing at each other (perhaps
at kernel summit) until Linus comes in an tells everyone how it's going
to be.
next prev parent reply other threads:[~2019-03-12 20:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-10 13:35 Alexey Dobriyan
2019-03-12 0:38 ` Andrew Morton
2019-03-12 17:24 ` Alexey Dobriyan
2019-03-12 19:50 ` Andrew Morton
2019-03-12 20:18 ` Alexey Dobriyan
2019-03-12 20:53 ` Andrew Morton [this message]
2019-03-12 20:24 ` Alexey Dobriyan
2022-02-25 8:15 Alexey Dobriyan
2022-02-25 10:01 ` David Laight
2022-02-25 17:24 ` Alexey Dobriyan
2022-02-26 1:10 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312135334.9dca95d348bb6c0fdc869fe9@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome