From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>,
Willy Tarreau <willy@haproxy.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/5] auxdisplay: charlcd: Move to_priv() to charlcd namespace
Date: Tue, 12 Mar 2019 17:33:00 +0200 [thread overview]
Message-ID: <20190312153300.GG9224@smile.fi.intel.com> (raw)
In-Reply-To: <CAMuHMdXML44wRji=VGU95kWnEj+zubha7N-L79f6Uz_bDbGAMw@mail.gmail.com>
On Tue, Mar 12, 2019 at 04:07:37PM +0100, Geert Uytterhoeven wrote:
> Hi Andy,
>
> On Tue, Mar 12, 2019 at 3:44 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > In order to be more particular in names, rename to_priv() macro
> > to charlcd_to_priv().
>
> As this is a macro, not a function, the name doesn't end up as a symbol in
> the binary anyway, and it's for internal use by the driver only.
I understand this, and I did in order to avoid potential collisions
in the future.
>
> > No functional change intended.
> >
> > Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Regardless:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thanks!
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-03-12 15:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 14:44 [PATCH v2 0/5] auxdisplay: Introduce charlcd_free() Andy Shevchenko
2019-03-12 14:44 ` [PATCH v2 1/5] auxdisplay: hd44780: Fix memory leak on ->remove() Andy Shevchenko
2019-03-12 15:05 ` Geert Uytterhoeven
2019-03-12 14:44 ` [PATCH v2 2/5] auxdisplay: charlcd: Move to_priv() to charlcd namespace Andy Shevchenko
2019-03-12 15:07 ` Geert Uytterhoeven
2019-03-12 15:33 ` Andy Shevchenko [this message]
2019-03-12 14:44 ` [PATCH v2 3/5] auxdisplay: charlcd: Introduce charlcd_free() helper Andy Shevchenko
2019-03-12 15:08 ` Geert Uytterhoeven
2019-03-12 14:44 ` [PATCH v2 4/5] auxdisplay: panel: Convert to use charlcd_free() Andy Shevchenko
2019-03-12 15:10 ` Geert Uytterhoeven
2019-03-12 14:44 ` [PATCH v2 5/5] auxdisplay: hd44780: " Andy Shevchenko
2019-03-12 15:11 ` Geert Uytterhoeven
2019-03-12 15:11 ` [PATCH v2 0/5] auxdisplay: Introduce charlcd_free() Miguel Ojeda
2019-03-12 15:46 ` Andy Shevchenko
2019-03-17 7:40 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312153300.GG9224@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=willy@haproxy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome