From: Morris Ku <saumah@gmail.com>
To: gregkh@linuxfoundation.org
Cc: morris_ku@sunix.com, linux-kernel@vger.kernel.org, arnd@arndb.de,
Morris Ku <saumah@gmail.com>
Subject: [PATCH] respond:Add header file,Kconfig and Makefile
Date: Wed, 13 Mar 2019 21:32:18 +0800 [thread overview]
Message-ID: <20190313133218.14568-1-saumah@gmail.com> (raw)
Hi Randy,
Thanks for review, my replies are inline:
Signed-off-by: Morris Ku <saumah@gmail.com>
---
+On 3/8/19 4:35 AM, Morris Ku wrote:
+> This patch add header file, Kconfig and Makefile.
+>
+> Signed-off-by: Morris Ku <saumah@gmail.com>
+> ---
+
+> diff --git a/char/snx/Kconfig b/char/snx/Kconfig
+> new file mode 100644
+> index 00000000..86f38352
+> --- /dev/null
+> +++ b/char/snx/Kconfig
+> @@ -0,0 +1,15 @@
+> +# SPDX-License-Identifier: GPL-2.0
+> +#
+> +# Character device configuration
+> +#
+> +
+> +config SNX
+> + tristate "SUNIX Multi-IO Board Drvier"
+
+ Driver
+
+> + Driver for SUNIX Multi-I/O Board device driver Based on
+> + drivers/char/serial.c, parport_pc.c, ppdev.c and lp.c by Linus
+> + Torvalds, Theodore Ts'o.
+
+kconfig does not like those 3 lines above. That indicates some lack of
+testing.
+
+They could be put under "help", but they really should just be deleted or
+moved to some source file if you think that they are needed.
+
ok , I'll delete Kconfig in next version.
+
+
+> + help
+> + Say Y here if you have a SUNIX Multi-IO card.
+
+Indent with tab + 2 spaces, not 3 spaces.
+
+> +
+> + To compile this driver as a module, choose M here: the
+> + module will be called snx.
--
2.17.1
reply other threads:[~2019-03-13 13:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190313133218.14568-1-saumah@gmail.com \
--to=saumah@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=morris_ku@sunix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®