From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Peter Rosin <peda@axentia.se>,
Robert Shearman <robertshearman@gmail.com>,
Guenter Roeck <linux@roeck-us.net>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Robert Shearman <robert.shearman@att.com>
Subject: Re: [PATCH v4 3/3] i2c: mux: pca954x: allow management of device idle state via sysfs
Date: Wed, 13 Mar 2019 14:14:10 -0700 [thread overview]
Message-ID: <20190313211410.GB32331@kroah.com> (raw)
In-Reply-To: <20190313163610.qbuexiowfcqgqndu@ninjato>
On Wed, Mar 13, 2019 at 05:36:10PM +0100, Wolfram Sang wrote:
> Hi Greg,
>
> > > I was wondering if you think the below ABI addition looks sane to you?
> > I am not the i2c maintainer :)
>
> Peter is the i2c-mux maintainer, so I trust him very much on the I2C
> side of things. We just wondered if you'd notice a general flaw when
> exposing such an interface to userspace.
Ah, I see. No, looks fine to me, it's a single value, well documented,
should be just fine.
thanks,
greg k-h
prev parent reply other threads:[~2019-03-13 21:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 11:43 [PATCH v4 0/3] " Robert Shearman
2019-02-28 11:43 ` [PATCH v4 1/3] i2c: mux: pca954x: remove support for unused platform data Robert Shearman
2019-02-28 11:43 ` [PATCH v4 2/3] i2c: mux: pca9541: " Robert Shearman
2019-02-28 11:43 ` [PATCH v4 3/3] i2c: mux: pca954x: allow management of device idle state via sysfs Robert Shearman
2019-03-13 7:04 ` Peter Rosin
2019-03-13 15:20 ` Greg Kroah-Hartman
2019-03-13 16:36 ` Wolfram Sang
2019-03-13 21:14 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190313211410.GB32331@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=peda@axentia.se \
--cc=robert.shearman@att.com \
--cc=robertshearman@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®