From: Kangjie Lu <kjlu@umn.edu>
To: kjlu@umn.edu
Cc: pakki001@umn.edu, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2] btrfs: fix a NULL pointer dereference
Date: Thu, 14 Mar 2019 03:13:04 -0500 [thread overview]
Message-ID: <20190314081304.469-1-kjlu@umn.edu> (raw)
In-Reply-To: <fcdf722f-d128-03c0-99fb-a220f680193c@suse.com>
btrfs_lookup_block_group may fail and return NULL. The fix uses
assert to ensure cache is not NULL.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
---
V2: use assert as suggested by Nikolay Borisov <nborisov@suse.com>
---
fs/btrfs/extent-tree.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index 994f0cc41799..80d7c272d282 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -7303,6 +7303,7 @@ void btrfs_free_tree_block(struct btrfs_trans_handle *trans,
pin = 0;
cache = btrfs_lookup_block_group(fs_info, buf->start);
+ ASSERT(cache);
if (btrfs_header_flag(buf, BTRFS_HEADER_FLAG_WRITTEN)) {
pin_down_extent(fs_info, cache, buf->start,
--
2.17.1
next prev parent reply other threads:[~2019-03-14 8:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 7:50 [PATCH] " Kangjie Lu
2019-03-14 7:54 ` Nikolay Borisov
2019-03-14 8:02 ` Qu Wenruo
2019-03-14 8:03 ` Nikolay Borisov
2019-03-14 8:13 ` Kangjie Lu [this message]
2019-03-14 8:16 ` [PATCH v2] " Nikolay Borisov
2019-03-14 9:15 ` [PATCH] " Qu Wenruo
2019-03-14 9:18 ` Nikolay Borisov
2019-03-14 15:26 ` Kangjie Lu
2019-03-14 10:23 ` Su Yue
2019-03-14 15:41 ` Josef Bacik
2019-03-14 7:59 ` Qu Wenruo
2019-03-25 16:35 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190314081304.469-1-kjlu@umn.edu \
--to=kjlu@umn.edu \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pakki001@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®