From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4B51C43381 for ; Thu, 14 Mar 2019 13:37:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B78832184E for ; Thu, 14 Mar 2019 13:37:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727473AbfCNNhB (ORCPT ); Thu, 14 Mar 2019 09:37:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:37248 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726845AbfCNNhA (ORCPT ); Thu, 14 Mar 2019 09:37:00 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 731A32085A; Thu, 14 Mar 2019 13:36:59 +0000 (UTC) Date: Thu, 14 Mar 2019 09:36:57 -0400 From: Steven Rostedt To: Joel Fernandes Cc: "Paul E. McKenney" , linux-kernel@vger.kernel.org, rcu@vger.kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, luto@kernel.org, byungchul.park@lge.com Subject: Re: [PATCH tip/core/rcu 06/19] rcu: Add warning to detect half-interrupts Message-ID: <20190314093657.2c1a3485@gandalf.local.home> In-Reply-To: <20190314123159.GB101545@google.com> References: <20180829222047.319-6-paulmck@linux.vnet.ibm.com> <20190311133939.GA29747@google.com> <20190311222903.GR13351@linux.ibm.com> <20190312150514.GB249405@google.com> <20190312152034.GZ13351@linux.ibm.com> <20190313150948.GA84821@google.com> <20190313112726.01d974fc@gandalf.local.home> <20190313155155.GN13351@linux.ibm.com> <20190313125125.1a1fb2f3@gandalf.local.home> <20190313180730.GU13351@linux.ibm.com> <20190314123159.GB101545@google.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Mar 2019 08:31:59 -0400 Joel Fernandes wrote: > Oh thanks for pointing that out. Yes it does work for me. I agree with the > lockdep API addition and others could benefit from it too. I will incorporate > the lockdep API addition into the RCU patch, but let me know if I should > rather split it. I'd recommend splitting it (adding the lockdep_assert in a patch by itself), but make sure that patch Cc's the lockdep maintainers and explains the reason for adding it. Might as well Cc the lockdep maintainers on the entire series too. -- Steve