From: David Sterba <dsterba@suse.cz>
To: Kangjie Lu <kjlu@umn.edu>
Cc: Jiri Kosina <jikos@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <JSlaby@suse.com>,
pakki001@umn.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: ipwireless: fix missing checks for ioremap
Date: Thu, 14 Mar 2019 13:35:51 +0100 [thread overview]
Message-ID: <20190314123550.GI31119@suse.cz> (raw)
In-Reply-To: <20190314070534.17819-1-kjlu@umn.edu>
On Thu, Mar 14, 2019 at 02:05:32AM -0500, Kangjie Lu wrote:
> ipw->attr_memory and ipw->common_memory are assigned with the
> return value of ioremap. ioremap may fail, but not checks
> are enforced. The fix insertss the checks.
Please fix the typos and resend, otherwise ok. Thanks.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Reviewed-by: David Sterba <dsterba@suse.com>
next prev parent reply other threads:[~2019-03-14 12:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 7:05 Kangjie Lu
2019-03-14 12:35 ` David Sterba [this message]
2019-03-15 7:07 ` [PATCH v2] " Kangjie Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190314123550.GI31119@suse.cz \
--to=dsterba@suse.cz \
--cc=JSlaby@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=jikos@kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=pakki001@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®