From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=GgR0=RR=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id B56E6C43381
	for <linux-kernel@archiver.kernel.org>; Thu, 14 Mar 2019 22:19:12 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 88CFE21871
	for <linux-kernel@archiver.kernel.org>; Thu, 14 Mar 2019 22:19:12 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728016AbfCNWTL (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 14 Mar 2019 18:19:11 -0400
Received: from mail.kernel.org ([198.145.29.99]:56176 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727055AbfCNWTL (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 14 Mar 2019 18:19:11 -0400
Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id D55242186A;
        Thu, 14 Mar 2019 22:19:09 +0000 (UTC)
Date:   Thu, 14 Mar 2019 18:19:08 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Frank Rowand <frowand.list@gmail.com>
Cc:     linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
        Tom Zanussi <tom.zanussi@linux.intel.com>,
        Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>,
        Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [PATCH] tracing: initialize variable in create_dyn_event()
Message-ID: <20190314181908.0af526af@gandalf.local.home>
In-Reply-To: <2872713a-8b99-5117-27df-eeda824e55a0@gmail.com>
References: <1548382670-30266-1-git-send-email-frowand.list@gmail.com>
        <2872713a-8b99-5117-27df-eeda824e55a0@gmail.com>
X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 14 Mar 2019 14:05:02 -0700
Frank Rowand <frowand.list@gmail.com> wrote:

> Hi Steve,
> 
> Ping.

Thanks, this got buried.

> >  static int create_dyn_event(int argc, char **argv)
> >  {
> >  	struct dyn_event_operations *ops;
> > -	int ret;
> > +	int ret = 0;

Probably should be ret = -ENODEV;

As if ret doesn't get set, then no dynamic code has been registered,
and something is truly wrong.

-- Steve


> >  
> >  	if (argv[0][0] == '-' || argv[0][0] == '!')
> >  		return dyn_event_release(argc, argv, NULL);
> >