From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Valdis Kletnieks <valdis.kletnieks@vt.edu>
Subject: [PATCH 1/8] tracing/probes: Make reserved_field_names static
Date: Fri, 15 Mar 2019 14:45:06 -0400 [thread overview]
Message-ID: <20190315184536.337893671@goodmis.org> (raw)
In-Reply-To: <20190315184505.655928086@goodmis.org>
From: =?UTF-8?q?Valdis=20Kl=C4=93tnieks?= <valdis.kletnieks@vt.edu>
sparse complains:
CHECK kernel/trace/trace_probe.c
kernel/trace/trace_probe.c:16:12: warning: symbol 'reserved_field_names' was not declared. Should it be static?
Yes, it should be static.
Link: http://lkml.kernel.org/r/2478.1552380778@turing-police
Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
kernel/trace/trace_probe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
index 89da34b326e3..cfcf77e6fb19 100644
--- a/kernel/trace/trace_probe.c
+++ b/kernel/trace/trace_probe.c
@@ -13,7 +13,7 @@
#include "trace_probe.h"
-const char *reserved_field_names[] = {
+static const char *reserved_field_names[] = {
"common_type",
"common_flags",
"common_preempt_count",
--
2.20.1
next prev parent reply other threads:[~2019-03-15 18:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 18:45 [PATCH 0/8] [GIT PULL] tracing: Minor clean ups, fixes and error checking Steven Rostedt
2019-03-15 18:45 ` Steven Rostedt [this message]
2019-03-15 18:45 ` [PATCH 2/8] trace/probes: Remove kernel doc style from non kernel doc comment Steven Rostedt
2019-03-15 18:45 ` [PATCH 3/8] tracing: kdb: Fix ftdump to not sleep Steven Rostedt
2019-03-15 18:45 ` [PATCH 4/8] tracing/probe: Check maxactive error cases Steven Rostedt
2019-03-15 18:45 ` [PATCH 5/8] tracing/probe: Check event name length correctly Steven Rostedt
2019-03-15 18:45 ` [PATCH 6/8] tracing/probe: Check the size of argument name and body Steven Rostedt
2019-03-15 18:45 ` [PATCH 7/8] tracing/probe: Check event/group naming rule at parsing Steven Rostedt
2019-03-15 18:45 ` [PATCH 8/8] tracing/probe: Verify alloc_trace_*probe() result Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190315184536.337893671@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome