Re: [PATCH 0/1] platform/x86: dell-wmi: Uncomment events that were

["Pali Rohár" <pali.rohar@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1646 bytes --]

On Friday 15 March 2019 22:09:41 Renato Soma wrote:
> Hello,
> 
> I noted that by pressing the "Dell Audio with Preset Switch" on my Dell
> 5420, notification messages are displayed at dmesg.
> That is happening because the keys are commented out and marked as
> untested.
> Since the logs purpose are there only for notification and considering
> the history of cases similar to this one, this patch aims to ignore
> those logs. Furthermore, this patch fixes the comments related to the
> keys, since they are marked as "Windows Mobility Center" button, which
> is incorrect.
> 
> Do note that the event 0xe02a is generated when pushing the button and
> the event 0xe02b is generated when releasing the button, hence the
> comment on the code.
> 
> Finally, as explained earlier, this was tested on an Inspiron 5420, but
> this model shares the specifications of the Inspiron 7520.
> 
> Thanks,
> Renato
> 
> Renato Soma (1):
>   platform/x86: dell-wmi: Uncomment events that were untested
> 
>  drivers/platform/x86/dell-wmi.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Hello!

Looks like that those keys are not as obvious as you wrote. Look at my
email with some investigation about Dell Audio With Preset Switch key:
https://www.spinics.net/lists/platform-driver-x86/msg15593.html

Also there is another user who wrote about 0xe02c key generated by
Inspirion 7520: https://ubuntuforum-br.org/index.php?topic=105434.0

You can a testing machine 5420, can you prove that behavior described in
my previous email match also your machine?

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]