From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8BD9C43381 for ; Sun, 17 Mar 2019 10:13:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8F1E821019 for ; Sun, 17 Mar 2019 10:13:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727059AbfCQKNq (ORCPT ); Sun, 17 Mar 2019 06:13:46 -0400 Received: from a.mx.secunet.com ([62.96.220.36]:58304 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726058AbfCQKNq (ORCPT ); Sun, 17 Mar 2019 06:13:46 -0400 Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id B104B20257; Sun, 17 Mar 2019 11:13:44 +0100 (CET) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CDrnVdk8PZRg; Sun, 17 Mar 2019 11:13:39 +0100 (CET) Received: from mail-essen-01.secunet.de (mail-essen-01.secunet.de [10.53.40.204]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id 66817201C1; Sun, 17 Mar 2019 11:13:39 +0100 (CET) Received: from gauss2.secunet.de (10.182.7.193) by mail-essen-01.secunet.de (10.53.40.204) with Microsoft SMTP Server id 14.3.439.0; Sun, 17 Mar 2019 11:13:39 +0100 Received: by gauss2.secunet.de (Postfix, from userid 1000) id 0B1BE318060C; Sun, 17 Mar 2019 11:13:39 +0100 (CET) Date: Sun, 17 Mar 2019 11:13:39 +0100 From: Steffen Klassert To: Herbert Xu CC: Su Yanjun , , , , , , Eric Dumazet Subject: Re: [PATCH] xfrm6_tunnel: Fix potential panic when unloading xfrm6_tunnel module Message-ID: <20190317101338.GQ6035@gauss3.secunet.de> References: <1552546782-102587-1-git-send-email-suyj.fnst@cn.fujitsu.com> <20190315062438.id3664ccow5uxgvt@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20190315062438.id3664ccow5uxgvt@gondor.apana.org.au> User-Agent: Mutt/1.9.4 (2018-02-28) X-G-Data-MailSecurity-for-Exchange-State: 0 X-G-Data-MailSecurity-for-Exchange-Error: 0 X-G-Data-MailSecurity-for-Exchange-Sender: 23 X-G-Data-MailSecurity-for-Exchange-Server: d65e63f7-5c15-413f-8f63-c0d707471c93 X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 X-G-Data-MailSecurity-for-Exchange-Guid: 881F5785-CE43-43DA-B585-DD0F32861033 X-G-Data-MailSecurity-for-Exchange-ProcessedOnRouted: True Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 15, 2019 at 02:24:38PM +0800, Herbert Xu wrote: > On Thu, Mar 14, 2019 at 02:59:42PM +0800, Su Yanjun wrote: > > When unloading xfrm6_tunnel module, xfrm6_tunnel_fini directly > > frees the xfrm6_tunnel_spi_kmem. Maybe someone has gotten the > > xfrm6_tunnel_spi, so need to wait it. > > > > Fixes: 91cc3bb0b04ff("xfrm6_tunnel: RCU conversion") > > Signed-off-by: Su Yanjun > > --- > > net/ipv6/xfrm6_tunnel.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > This looks good to me. And it's not just the matter of accessing > freed memory. A worse problem would be trying to execute code > from an unloaded module. > > Acked-by: Herbert Xu Applied, thanks everyone!