mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Bharath Vedartham <linux.bhar@gmail.com>
Cc: gaoxiang25@huawei.com, yuchao0@huawei.com,
	linux-erofs@lists.ozlabs.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: erofs: Add whitespace after declaration
Date: Sun, 17 Mar 2019 12:11:50 +0100	[thread overview]
Message-ID: <20190317111150.GB4614@kroah.com> (raw)
In-Reply-To: <20190316112958.GA29023@bharath12345-Inspiron-5559>

On Sat, Mar 16, 2019 at 04:59:58PM +0530, Bharath Vedartham wrote:
> Fix the checkpatch.pl warning to add a whitespace after declaration
> statements.
> 
> Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
> ---
> Changes since v2
> 	- Mutt was giving me a few problems. I apologise for the
> 	  previous poor patches.
> ---
>  drivers/staging/erofs/inode.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c
> index 924b8df..9a36a1f 100644
> --- a/drivers/staging/erofs/inode.c
> +++ b/drivers/staging/erofs/inode.c
> @@ -270,8 +270,8 @@ struct inode *erofs_iget(struct super_block *sb,
>  	if (inode->i_state & I_NEW) {
>  		int err;
>  		struct erofs_vnode *vi = EROFS_V(inode);
> -		vi->nid = nid;
>  
> +		vi->nid = nid;
>  		err = fill_inode(inode, isdir);
>  		if (likely(!err))
>  			unlock_new_inode(inode);
> @@ -305,4 +305,3 @@ const struct inode_operations erofs_fast_symlink_iops = {
>  #endif
>  	.get_acl = erofs_get_acl,
>  };
> -

You also removed the last line of the file, which you did not mention :(


      reply	other threads:[~2019-03-17 11:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-16 11:29 Bharath Vedartham
2019-03-17 11:11 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190317111150.GB4614@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=gaoxiang25@huawei.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux.bhar@gmail.com \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®