From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40747C43381 for ; Sun, 17 Mar 2019 18:30:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EF8A6206DF for ; Sun, 17 Mar 2019 18:30:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n0tFaXWh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727202AbfCQSa4 (ORCPT ); Sun, 17 Mar 2019 14:30:56 -0400 Received: from mail-qk1-f195.google.com ([209.85.222.195]:37441 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726349AbfCQSa4 (ORCPT ); Sun, 17 Mar 2019 14:30:56 -0400 Received: by mail-qk1-f195.google.com with SMTP id c1so8419390qkk.4; Sun, 17 Mar 2019 11:30:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=wcjAgXMxaZ1t4MHbpg/y1kaYaozUNYkr7E15q7Q/JMw=; b=n0tFaXWhsVNA7jtiVcTw55/B9fLz9ogS+ZjQ3WG0UgttDmgcskOAOTl3Fk6lpwGvSE 1c3ojNBn8bzowyV+HrxdRgXEMk2sfT0CwVVDBHMRhwYDCAt2EBK7IvgJBO4iSSaaRoKt /w8E+PTy0FACu2czME/KamB2yMJmxKn3pUCSNIl0yFAbuFgxXXX9j43LpA5MMUDBzESB qs9NsSdHJFUQakXiVC72/30OisVcxfIW3SaniCy1BOTMi5dBuebIs4/xlPx7BTDl2UbH gT3FDYqlhU+Z9vnB43toryvIip1isC65TI5aiuWqT37eXh2Y9cB4g+3mcDKfhr0XV+cH 821g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=wcjAgXMxaZ1t4MHbpg/y1kaYaozUNYkr7E15q7Q/JMw=; b=hjSXb1UKGhhgR2g4dFOrbvXQvyCwlVqHu57gJYexXoNJsVD8GeC7xC1qg8S5lkebgS aHoGf8A4ZkGOh+nOt4FvriYM82RJyRkV3DCFUtkz9nkncaxEiElQCPgw8AH62cpKDCG+ /K5tiK5ndgU4gUaqahV59EU8Z/9nfZ84FX5RijfjXvviK+8em01LaSq0bEDlSuWVy2eh g0qVKILcwMmOkThY0NfQvAvyMvBb5wb5Jdrlu9SRWpVfooml7qT6xdJrVWXu5UzKYX4y umOC6KBnqD1Cl2mjnr3MLMf0oSfJIUs4RUv64K1Zog9okWsdBc5dzuKWD0uWCUb03Skx DkoA== X-Gm-Message-State: APjAAAXwKeGLox7nEXDpZDCnnXalWhc2XMe6GsWsJ9HkbX1aTrrqe5CZ uH7eEM4SPtOj6RI1zJwXMuQ= X-Google-Smtp-Source: APXvYqwFsPI9SNIAPlWtZI9QbHGIrJYatu0kiiipoc1Iq82LP2I3Sk97S2Bx0F+qFH55z/pUo+0ENw== X-Received: by 2002:a05:620a:10b1:: with SMTP id h17mr10552426qkk.69.1552847454723; Sun, 17 Mar 2019 11:30:54 -0700 (PDT) Received: from rys-Inspiron-5420 ([201.82.188.175]) by smtp.gmail.com with ESMTPSA id a8sm130426qtc.19.2019.03.17.11.30.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 17 Mar 2019 11:30:53 -0700 (PDT) Date: Sun, 17 Mar 2019 15:30:49 -0300 From: Renato Soma To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Mario Limonciello Subject: Re: [PATCH 0/1] platform/x86: dell-wmi: Uncomment events that were Message-ID: <20190317183049.GA5989@rys-Inspiron-5420> References: <20190316010942.6448-1-renatoys08@gmail.com> <20190316091756.2zfccpnhfnjogktp@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190316091756.2zfccpnhfnjogktp@pali> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Sat, Mar 16, 2019 at 10:17:56AM +0100, Pali Rohár wrote: > > Looks like that those keys are not as obvious as you wrote. Look at my > email with some investigation about Dell Audio With Preset Switch key: > https://www.spinics.net/lists/platform-driver-x86/msg15593.html > > Also there is another user who wrote about 0xe02c key generated by > Inspirion 7520: https://ubuntuforum-br.org/index.php?topic=105434.0 > > You can a testing machine 5420, can you prove that behavior described in > my previous email match also your machine? > Thanks for the feedback, I was unaware of this issue. I've performed some tests in my machine and this is what I've found so far: ===================================================================== ---------------------------------------- Left WMI key: Windows Mobility Center Press: 'x' Hold: - Release: - In my machine (Inspiron 5420), whenever I press this key, the key outputs the character "x". I've seen nothing on dmesg even if I keep this key pressed for longer amounts of time. I'm still trying to understand why this is hapenning. ---------------------------------------- Middle WMI key: Dell Audio With Preset Switch Press: Key with type 0x0000 and code 0xe02a pressed Hold: - Release: Key with type 0x0000 and code 0xe02b pressed Differently from what you saw on a Inspiron 7520, I could not reproduce the behavior that you reported on the first link above. In my case, when I press the key, the code 0xe02a is shown at dmesg only once. Also, even though I keep it pressed for longer than ~30 seconds or so, I could not see the entry 0xe02c apper. More on that behavior later on. When releasing the key, I can see the code 0xe02b show up at dmesg. ---------------------------------------- Right WMI key: Dell Instant Launch Press: - Hold: - Release: - This key is with a really weird behavior on my machine. When testing, I would normally press and relase so that the following messages would pop-up: [ 2830.499420] atkbd serio0: Unknown key pressed (translated set 2, code 0x60 on isa0060/serio0). [ 2830.499422] atkbd serio0: Use 'setkeycodes 60 ' to make it known. But what I realized was that, if I kept this button pressed for about ~3 seconds or so (like when your experiment in the link above), dmesg would not ouput anything untill those ~3 seconds elapsed. When they did, then dmesg log would have the following entries: [ 3058.494003] atkbd serio0: Unknown key pressed (translated set 2, code 0x60 on isa0060/serio0). [ 3058.494008] atkbd serio0: Use 'setkeycodes 60 ' to make it known. [ 3058.501494] dell_wmi: Unknown key with type 0x0000 and code 0xe028 pressed The last message being the weirdest, It would seem that only after about 3 seconds or so, the driver is being notified of it. ===================================================================== Anyway, It's clear now that this patch trully makes no sense since the hardwares (Inspiron 7520 x Inspiron 5420) are behaving somewhat differently on these keys. Either way, It seems that at both of them, there are three behaviors that are strange. I'm still trying to learn kernel development (I'm a newbie) so could you please point out whether this is worth it to investigate, or if should I leave this as is? In the meantime, I'll try to find out why the first button is outputting an "x" character on my machine. Thanks! Renato