From: David Miller <davem@davemloft.net>
To: willemdebruijn.kernel@gmail.com
Cc: maxime.chevallier@bootlin.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, willemb@google.com, edumazet@google.com,
antoine.tenart@bootlin.com, thomas.petazzoni@bootlin.com
Subject: Re: [PATCH net] packets: Always register packet sk in the same order
Date: Mon, 18 Mar 2019 17:59:48 -0700 (PDT) [thread overview]
Message-ID: <20190318.175948.1678106009838663617.davem@davemloft.net> (raw)
In-Reply-To: <20190316.182119.1641693988840475497.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Sat, 16 Mar 2019 18:21:19 -0700 (PDT)
> From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
> Date: Sat, 16 Mar 2019 14:09:33 -0400
>
>> Note that another consequence of this patch is that insertion on
>> packet create is now O(N) with the number of active packet sockets,
>> due to sklist being an hlist.
>
> Exploitable...
After reading Willem's explanation of how the scope of such a problem
is constrained, I am going to apply this and queue it up for -stable.
Maybe in the long term we can do the hlist reverse RCU thing.
prev parent reply other threads:[~2019-03-19 0:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-16 13:41 Maxime Chevallier
2019-03-16 18:09 ` Willem de Bruijn
2019-03-17 1:21 ` David Miller
2019-03-17 16:42 ` Willem de Bruijn
2019-03-19 0:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318.175948.1678106009838663617.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=antoine.tenart@bootlin.com \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®