mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Roman Kiryanov <rkir@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Sebastian Reichel <sebastian.reichel@collabora.com>
Subject: Re: [PATCH] drivers: power: supply: goldfish_battery: Fix bogus SPDX identifier
Date: Tue, 19 Mar 2019 17:52:08 +0100	[thread overview]
Message-ID: <20190319165208.GA21123@kroah.com> (raw)
In-Reply-To: <CAOGAQepj=yW4uQSRHpvnQz71+D8a7+H71XtrApp8YGU65XgoqA@mail.gmail.com>

On Tue, Mar 19, 2019 at 09:14:32AM -0700, Roman Kiryanov wrote:
> Hi, I am sorry for this warning. I remember I checked all changes I
> sent, maybe missed this one.
> 
> At the bottom the file says
> 
> MODULE_LICENSE("GPL");
> 
> and
> 
> // SPDX-License-Identifier: GPL-2.0
> 
> makes it inconsistent.

No, please read include/linux/module.h in 5.1-rc1, that nightmare is now fixed up.

Also, you were inconsistent from the beginning with the text at the top
of the file, so that was your issue to start with :)

Also, please do not top post.

thanks,

greg k-h

  reply	other threads:[~2019-03-19 16:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-19 14:51 Thomas Gleixner
2019-03-19 16:14 ` Roman Kiryanov
2019-03-19 16:52   ` Greg KH [this message]
2019-03-20  8:14   ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190319165208.GA21123@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rkir@google.com \
    --cc=sebastian.reichel@collabora.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®