From: Bart Van Assche <bvanassche@acm.org>
To: Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Bart Van Assche <bvanassche@acm.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Alexander Duyck <alexander.h.duyck@linux.intel.com>,
Dan Williams <dan.j.williams@intel.com>
Subject: [PATCH] kernel/workqueue: Verify alloc_workqueue() argument list consistency
Date: Tue, 19 Mar 2019 10:40:47 -0700 [thread overview]
Message-ID: <20190319174047.89815-1-bvanassche@acm.org> (raw)
This patch avoids that gcc reports the following warning when building
with W=1:
kernel/workqueue.c:4250:2: warning: function alloc_workqueue might be a candidate for gnu_printf format attribute [-Wsuggest-attribute=format]
vsnprintf(wq->name, sizeof(wq->name), fmt, args);
Cc: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: Alexander Duyck <alexander.h.duyck@linux.intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Fixes: 669de8bda87b ("kernel/workqueue: Use dynamic lockdep keys for workqueues")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
include/linux/workqueue.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
index d59525fca4d3..30737b5183c0 100644
--- a/include/linux/workqueue.h
+++ b/include/linux/workqueue.h
@@ -404,6 +404,7 @@ extern struct workqueue_struct *system_freezable_power_efficient_wq;
* RETURNS:
* Pointer to the allocated workqueue on success, %NULL on failure.
*/
+__printf(1, 4)
struct workqueue_struct *alloc_workqueue(const char *fmt,
unsigned int flags,
int max_active, ...);
--
2.21.0.155.ge902e9bcae20
next reply other threads:[~2019-03-19 17:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 17:40 Bart Van Assche [this message]
2019-04-15 17:09 ` Bart Van Assche
2019-04-15 20:46 ` Alexander Duyck
2019-04-16 14:56 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319174047.89815-1-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=alexander.h.duyck@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®