From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C0F9C43381 for ; Thu, 21 Mar 2019 15:41:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 414BD218FD for ; Thu, 21 Mar 2019 15:41:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="Fp6pwiPS"; dkim=pass (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="soCUeVA/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728473AbfCUPlF (ORCPT ); Thu, 21 Mar 2019 11:41:05 -0400 Received: from node.akkea.ca ([192.155.83.177]:39186 "EHLO node.akkea.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726787AbfCUPlC (ORCPT ); Thu, 21 Mar 2019 11:41:02 -0400 Received: from localhost (localhost [127.0.0.1]) by node.akkea.ca (Postfix) with ESMTP id 51AA84E2051; Thu, 21 Mar 2019 15:41:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1553182861; bh=bPDUZ8GMtcCtdtEBE3Hh0GPN7PC9bETs8gr9/++eQAw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Fp6pwiPSWbtsOiOw5MtHSjhRVrUmZG9+7WAPfHSC/nwR3g3tYjtCUApjpYgjEC83f l8or63dRVelUU12OgDz9x9ROPJ4vxvqDCeFWS9nTC58p3gXkgwzY2/7jqIv/zcPWRg cKedagUkYzl38P+i/LKm+uvpiXYaBR8KdEg4r4x4= X-Virus-Scanned: Debian amavisd-new at mail.akkea.ca Received: from node.akkea.ca ([127.0.0.1]) by localhost (mail.akkea.ca [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WdTDGA1HT8tK; Thu, 21 Mar 2019 15:41:00 +0000 (UTC) Received: from midas.localdomain (S0106788a2041785e.gv.shawcable.net [70.66.86.75]) by node.akkea.ca (Postfix) with ESMTPSA id DDFBB4E204D; Thu, 21 Mar 2019 15:40:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1553182860; bh=bPDUZ8GMtcCtdtEBE3Hh0GPN7PC9bETs8gr9/++eQAw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=soCUeVA/KwCIuWIrwxgM+cUvXrHGnra49F06Nm0O/ARiQ+kS8lffdDteUiyDLVhYy WbOeM4I1H2tRPr0q5tdi2tVwDjm+0vV4cPRGn99oo0uOYn+f9fuO3y8qs1OFulU1hu qVkndgaRV3/E53QBJ2RrjOXA9soG3hzJw7IG4u98= From: "Angus Ainslie (Purism)" To: jic23@kernel.org Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Mark Rutland , "Angus Ainslie (Purism)" , Tomas Novotny , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/5] iio: light: vcnl4000 use word writes instead of byte writes Date: Thu, 21 Mar 2019 08:40:43 -0700 Message-Id: <20190321154047.23236-2-angus@akkea.ca> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190321154047.23236-1-angus@akkea.ca> References: <20190321154047.23236-1-angus@akkea.ca> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The VCNL4200 datasheet says that word read and writes should be used to access the registers. Signed-off-by: Angus Ainslie (Purism) Tested-by: Tomas Novotny --- drivers/iio/light/vcnl4000.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index 04fd0d4b6f19..5e0a8eb83ebc 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -140,10 +140,10 @@ static int vcnl4200_init(struct vcnl4000_data *data) data->rev = (ret >> 8) & 0xf; /* Set defaults and enable both channels */ - ret = i2c_smbus_write_byte_data(data->client, VCNL4200_AL_CONF, 0x00); + ret = i2c_smbus_write_word_data(data->client, VCNL4200_AL_CONF, 0); if (ret < 0) return ret; - ret = i2c_smbus_write_byte_data(data->client, VCNL4200_PS_CONF1, 0x00); + ret = i2c_smbus_write_word_data(data->client, VCNL4200_PS_CONF1, 0); if (ret < 0) return ret; -- 2.17.1