From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DCA0C43381 for ; Thu, 21 Mar 2019 15:49:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 56D0F218A5 for ; Thu, 21 Mar 2019 15:49:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728541AbfCUPta (ORCPT ); Thu, 21 Mar 2019 11:49:30 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:48247 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728016AbfCUPt3 (ORCPT ); Thu, 21 Mar 2019 11:49:29 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1h6zwa-0001h6-JK; Thu, 21 Mar 2019 16:49:24 +0100 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1h6zwa-0007Zh-2j; Thu, 21 Mar 2019 16:49:24 +0100 Date: Thu, 21 Mar 2019 16:49:24 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Arnd Bergmann Cc: Mark Brown , Boris Brezillon , Geert Uytterhoeven , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] spi: export tracepoint symbols to modules Message-ID: <20190321154924.e5naj2bpdxp7krjb@pengutronix.de> References: <20190321124240.901884-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190321124240.901884-1-arnd@arndb.de> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 21, 2019 at 01:42:25PM +0100, Arnd Bergmann wrote: > The newly added tracepoints in the spi-mxs driver cause a link > error when the driver is a loadable module: > > ERROR: "__tracepoint_spi_transfer_stop" [drivers/spi/spi-mxs.ko] undefined! > ERROR: "__tracepoint_spi_transfer_start" [drivers/spi/spi-mxs.ko] undefined! > > I'm not quite sure where to put the export statements, but > directly after the inclusion of the header seems as good as > any other place. I agree it looks a bit ugly, but I don't have a better idea either. > > Fixes: f3fdea3af405 ("spi: mxs: add tracing to custom .transfer_one_message callback") > Signed-off-by: Arnd Bergmann Looks right: Acked-by: Uwe Kleine-König Thanks for finding and fixing that. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |