From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3730C43381 for ; Thu, 21 Mar 2019 19:32:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C0B73218FD for ; Thu, 21 Mar 2019 19:32:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="O/uL1A+T" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728615AbfCUTcN (ORCPT ); Thu, 21 Mar 2019 15:32:13 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:57822 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727909AbfCUTcN (ORCPT ); Thu, 21 Mar 2019 15:32:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=iJevomLrRZClFm0EVC7UOBsPFA5StB1k3xKEUmwQLHQ=; b=O/uL1A+T5W09tmeQX6qLweipq VChSUL4/KwiqWYHXukI80jnFxOjAVH9WQL7ovamTWWEMkE5o6fnR1X6ZzoWdmunSGB3hwBfDwywEX frdYq1xz9Sam5m28p8vlFh1OsKl9oOSg5eq7zGARwIyMbCDZAGVHcJK463CKiD9OuotAvocfHFHEl EriT6mLxhNCKW2hCcMXcB0kqne5Ax4YWlMJVJKs0URndfWccKWwyKkz0D3IyTXGLp9lZ/a+ol/Mz9 zABmwWKsOeZTc2kZIwwgAU1rIiUnt+rtFbp8y1Fn8SyVNe8RQylLFUdVhm0C3fQcFhQF+BIF3jFwD 2hhKHjUDA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1h73Pv-0008Jd-P4; Thu, 21 Mar 2019 19:31:56 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 37A88984EE8; Thu, 21 Mar 2019 20:31:52 +0100 (CET) Date: Thu, 21 Mar 2019 20:31:52 +0100 From: Peter Zijlstra To: Steven Rostedt Cc: Andy Lutomirski , Juergen Gross , LKML , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Joel Fernandes , He Zhe , Linus Torvalds , Clark Williams Subject: Re: [RFC][PATCH] tracing/x86: Save CR2 before tracing irqsoff on error_entry Message-ID: <20190321193152.GB2490@worktop.programming.kicks-ass.net> References: <20190320221534.165ab87b@oasis.local.home> <20190321083317.GL6058@hirez.programming.kicks-ass.net> <20190321090241.GL6521@hirez.programming.kicks-ass.net> <20190321104517.GM6521@hirez.programming.kicks-ass.net> <20190321093242.4a948198@gandalf.local.home> <20190321172203.GS5996@hirez.programming.kicks-ass.net> <20190321141020.641e313f@gandalf.local.home> <20190321182830.GV5996@hirez.programming.kicks-ass.net> <20190321145551.4c80c3a7@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190321145551.4c80c3a7@gandalf.local.home> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 21, 2019 at 02:55:51PM -0400, Steven Rostedt wrote: > On Thu, 21 Mar 2019 19:28:30 +0100 > Peter Zijlstra wrote: > > > On Thu, Mar 21, 2019 at 02:10:20PM -0400, Steven Rostedt wrote: > > > On Thu, 21 Mar 2019 11:05:06 -0700 > > > Andy Lutomirski wrote: > > > > > > > In the long run, I think the right solution is to rewrite even more of > > > > this mess in C. We really ought to be able to put the IRQ flag > > > > tracing and the context tracking into C code. > > > > > > And once we do that, we can work on getting the irq tracing > > > incorporated into a jump_label type that we could possibly enable > > > lockdep at start up, and then disable it later, even on production > > > systems! That is, to be able to turn it off and bring the system back > > > up to full speed. > > > > You forget the stupid amount of data bloat that lockdep brings. > > No I didn't. Some users only care about performance, but find memory > cheap. Because cache-misses are free?