From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44181C43381 for ; Fri, 22 Mar 2019 05:37:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 05D08218FC for ; Fri, 22 Mar 2019 05:37:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553233068; bh=vEj6MDvfvi5+o7E9dbvy4Ex3YdChPz9jwzNJi/OEplo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=qG8OnIe93eoDxR9gkdLdcIlROfliVOMIGNJqw6exn6FgKwT+f6Mqf7R3tIIKVbN4d AC7FSb95+uXec1mVAickd6OU+lC2qt+BQFuZHLCEgiEnPzy8I6n35ZuJOQmIGNdK7T Kfu98AYY7Xgqv9K+VrXXM61vJ0kKlQGR/8HJh60s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727745AbfCVFhq (ORCPT ); Fri, 22 Mar 2019 01:37:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:46248 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726162AbfCVFhq (ORCPT ); Fri, 22 Mar 2019 01:37:46 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EEC1A218B0; Fri, 22 Mar 2019 05:37:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553233065; bh=vEj6MDvfvi5+o7E9dbvy4Ex3YdChPz9jwzNJi/OEplo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B2qgywxH3J5axp3waQgKMyBU7NKwGKLtN24aR0dYqoKZfqYfE7JaeAwJukAtc3IgD ttiuWr7TeNsmNqiTdkDhB0SyI2TAwCZ1D9oxzNtluh7q9J7WY0GYwpGLcrNw0BGWQ2 Tc+1uUmTdfg1SiuI84lnQg4DHgwSsrMdYvY8YOHI= Date: Fri, 22 Mar 2019 06:37:42 +0100 From: Greg Kroah-Hartman To: Jochen Sprickerhof Cc: Marek Szyprowski , Roger Quadros , Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I Subject: Re: [PATCH] usb: dwc3: Softdep for GBit Ethernet on Odroid XU4 Message-ID: <20190322053742.GB31708@kroah.com> References: <20190321202303.GA1399@vis> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190321202303.GA1399@vis> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 21, 2019 at 09:23:03PM +0100, Jochen Sprickerhof wrote: > This adds a soft dependency to the dwc3 module to load it after > xhci-plat as proposed in: > > https://marc.info/?l=linux-usb&m=155230272022603&w=2 > > Old behaviour: > > $ lsusb -t > /: Bus 06.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 5000M > /: Bus 05.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 480M > |__ Port 1: Dev 2, If 0, Class=Vendor Specific Class, Driver=r8152, 480M > > New behaviour: > > $ lsusb -t > /: Bus 06.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 5000M > |__ Port 1: Dev 2, If 0, Class=Vendor Specific Class, Driver=r8152, 5000M > > Tested on Debian unstable using Linux 4.19.29. > > Note, this needs a hard reset when coming from an unpatched kernel. > > Signed-off-by: Jochen Sprickerhof > --- > drivers/usb/dwc3/core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > index 103807587dc6..9017e4ed9d99 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -1746,3 +1746,4 @@ MODULE_ALIAS("platform:dwc3"); > MODULE_AUTHOR("Felipe Balbi "); > MODULE_LICENSE("GPL v2"); > MODULE_DESCRIPTION("DesignWare USB3 DRD Controller Driver"); > +MODULE_SOFTDEP("pre: xhci_plat_hcd"); Your patch is corrupted and can not be applied :(