mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Kubecek <mkubecek@suse.cz>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: John Linville <linville@tuxdriver.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: New ethtool sub-feature and ethtool-netlink
Date: Fri, 22 Mar 2019 08:38:07 +0100	[thread overview]
Message-ID: <20190322073807.GL29968@unicorn.suse.cz> (raw)
In-Reply-To: <4ecd48b3-92d6-38a1-11db-5c7b6a0ae341@gmail.com>

On Thu, Mar 21, 2019 at 10:23:36PM +0100, Heiner Kallweit wrote:
> I have an ethtool extension in the pipe that adds one more PHY tunable
> sub-feature (for Fast Link Down support). Are smaller extensions still
> ok for ethtool,

Adding a new PHY tunable is IMHO minor change which doesn't need to wait
for the netlink interface. It's a bit more complicated due to the way
tunables (and PHY tunables) are implemented in ioctl API (which requires
both sides to have a list of tunables and their interpretation) but that
is one of the things I would like to change. :-)

After all, I don't have support for (PHY) tunables in the netlink API
yet (not even in the part which hasn't been submitted yet).

> or IOW: When do you think is ethtool-netlink going to be stable enough
> so that other developers can add features?

I would say that once it reaches mainline and userspace starts to use
it, it will have to be stable (due to "Linus' first commandment"). When
that is going to be, that depends on how the review is going, it's hard
to guess.

Michal

  reply	other threads:[~2019-03-22  7:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21 21:23 Heiner Kallweit
2019-03-22  7:38 ` Michal Kubecek [this message]
2019-03-23 14:32   ` Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190322073807.GL29968@unicorn.suse.cz \
    --to=mkubecek@suse.cz \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®