mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: Vladimir Kondratiev <vladimir.kondratiev@linux.intel.com>,
	Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] kbuild: gitignore output directory
Date: Fri, 22 Mar 2019 15:52:12 +0000	[thread overview]
Message-ID: <20190322155212.133029-1-andre.przywara@arm.com> (raw)
In-Reply-To: <20190203084840.6113-1-vladimir.kondratiev@intel.com>

Hi,

> When compiling into output directory using O=, many files
> created under KBUILD_OUTPUT that git considers
> as new ones; git clients, ex. "git gui" lists it, and it clutters
> file list making it difficult to see what was really changed
> 
> Generate .gitignore in output directory that ignores all
> its content

just found this when testing -rc1.
Unfortunately this breaks my setup, because I keep a totally separate
git repository in my build directories to track (various versions of)
.config. So .gitignore there is carefully crafted to ignore most build
artefacts, but not .config, for instance.

I am not sure how git would interact with the build directory for you?
Do you build into a subdirectory of the kernel tree?

I was hoping that we would not overwrite unrelated files in directories
outside of the kernel tree. In case this is about a subdirectory of the
source tree, can we somehow check for this case?

Cheers,
Andre.

> 
> Signed-off-by: Vladimir Kondratiev <vladimir.kondratiev@linux.intel.com>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>  Makefile | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index 97ee0be24d52..d487fca342c4 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -483,10 +483,13 @@ PHONY += outputmakefile
>  # outputmakefile generates a Makefile in the output directory, if using a
>  # separate output directory. This allows convenient use of make in the
>  # output directory.
> +# At the same time when output Makefile generated, generate .gitignore to
> +# ignore whole output directory
>  outputmakefile:
>  ifneq ($(KBUILD_SRC),)
>  	$(Q)ln -fsn $(srctree) source
>  	$(Q)$(CONFIG_SHELL) $(srctree)/scripts/mkmakefile $(srctree)
> +	$(Q){ echo "# this is build directory, ignore it"; echo "*"; } > .gitignore
>  endif
>  
>  ifneq ($(shell $(CC) --version 2>&1 | head -n 1 | grep clang),)
> -- 
> 2.17.1


  parent reply	other threads:[~2019-03-22 15:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-30 11:14 [PATCH] " Vladimir Kondratiev
2019-02-01  4:18 ` Masahiro Yamada
2019-02-03  8:48   ` [PATCH v2] " Vladimir Kondratiev
2019-02-05  8:15     ` Masahiro Yamada
2019-03-22 15:52     ` Andre Przywara [this message]
2019-03-24  2:22       ` Masahiro Yamada
2019-03-25 10:47         ` Andre Przywara
2019-02-03  8:50   ` [PATCH] " Vladimir Kondratiev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190322155212.133029-1-andre.przywara@arm.com \
    --to=andre.przywara@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vladimir.kondratiev@linux.intel.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®