From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: regression (bisected): "modprobe parport_pc" hangs in current mainline
Date: Sun, 24 Mar 2019 19:38:38 +0000 [thread overview]
Message-ID: <20190324193838.ubiljot22zhf5mjq@debian> (raw)
In-Reply-To: <1572645.oXzt2vILsi@alaris>
[-- Attachment #1: Type: text/plain, Size: 805 bytes --]
Hi Michal,
On Fri, Mar 22, 2019 at 07:13:23AM +0100, Michal Kubecek wrote:
> On Thursday, 21 March 2019 23:43 Sudip Mukherjee wrote:
> > HI Michal,
> >
> > On Wed, Mar 20, 2019 at 9:18 PM Michal Kubecek <mkubecek@suse.cz> wrote:
> > > On Wed, Mar 20, 2019 at 09:30:59AM +0000, Sudip Mukherjee wrote:
<snip>
> > Can you please check in your VM or machine what do you have the alias
> > as? It should be either in "/etc/modprobe.conf" or some conf file in
> > "/etc/modprobe.d" folder.
>
> You are right, this is in /etc/modprobe.d/00-system which is part of
> suse-module-tools package:
And I was able to reproduce the problem using a vm and Suse Tumblewood with
next-20190322. Can you please try the attached patch and test on your vm and
machine and check if it fixes the problem.
--
Regards
Sudip
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 499 bytes --]
diff --git a/drivers/parport/share.c b/drivers/parport/share.c
index 0171b8dbcdcd..f87948fbfc34 100644
--- a/drivers/parport/share.c
+++ b/drivers/parport/share.c
@@ -274,7 +274,7 @@ static int port_check(struct device *dev, void *dev_drv)
int __parport_register_driver(struct parport_driver *drv, struct module *owner,
const char *mod_name)
{
- if (list_empty(&portlist))
+ if (list_empty(&portlist) && strcmp(drv->name, "daisy_drv"))
get_lowlevel_driver();
if (drv->devmodel) {
next prev parent reply other threads:[~2019-03-24 19:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 6:45 Michal Kubecek
2019-03-17 17:01 ` Sudip Mukherjee
2019-03-17 18:05 ` Michal Kubecek
2019-03-20 9:30 ` Sudip Mukherjee
2019-03-20 21:18 ` Michal Kubecek
2019-03-21 22:43 ` Sudip Mukherjee
2019-03-22 6:13 ` Michal Kubecek
2019-03-24 19:38 ` Sudip Mukherjee [this message]
2019-03-25 7:30 ` Michal Kubecek
2019-03-25 10:00 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190324193838.ubiljot22zhf5mjq@debian \
--to=sudipm.mukherjee@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®