mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Guido Günther" <agx@sigxcpu.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	DRI mailing list <dri-devel@lists.freedesktop.org>,
	Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH v4 2/3] dt-bindings: Add Rocktech jh057n00900 panel bindings
Date: Mon, 25 Mar 2019 17:10:30 +0100	[thread overview]
Message-ID: <20190325161030.GA30679@bogon.m.sigxcpu.org> (raw)
In-Reply-To: <CAOMZO5BfhaR2BjBKvLwGk_=ULtGUx_x46jskX1WiAOY5vzxgbw@mail.gmail.com>

Hi,
On Mon, Mar 25, 2019 at 11:10:47AM -0300, Fabio Estevam wrote:
> On Mon, Mar 25, 2019 at 11:06 AM Guido Günther <agx@sigxcpu.org> wrote:
> 
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.txt
> > @@ -0,0 +1,18 @@
> > +Rocktech jh057n00900 5.5" 720x1440 TFT LCD panel
> > +
> > +Required properties:
> > +- compatible: should be "rocktech,jh057n00900"
> > +- reg: DSI virtual channel of the peripheral
> > +- reset-gpios: panel reset gpio
> > +- backlight: phandle of the backlight device attached to the panel
> > +
> > +Example:
> > +
> > +       &mipi_dsi {
> > +               panel {
> > +                       compatible = "rocktech,jh057n00900";
> > +                       reg = <0>;
> 
> Passing the reg property without its corresponding @0 would cause a
> dtc warning when building with W=1.

Thanks, I've put that in for v5 and sent a patch to correct
the other drivers in display/panel:

  https://patchwork.kernel.org/patch/10869563/

Cheers,
 -- Guido
    

  reply	other threads:[~2019-03-25 16:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-25 14:06 [PATCH v4 0/3] drm/panel: Support Rocktech jh057n00900 DSI panel Guido Günther
2019-03-25 14:06 ` [PATCH v4 1/3] dt-bindings: Add vendor prefix for ROCKTECH DISPLAYS LIMITED Guido Günther
2019-03-25 14:06 ` [PATCH v4 2/3] dt-bindings: Add Rocktech jh057n00900 panel bindings Guido Günther
2019-03-25 14:10   ` Fabio Estevam
2019-03-25 16:10     ` Guido Günther [this message]
2019-03-25 14:06 ` [PATCH v4 3/3] drm/panel: Add Rocktech jh057n00900 panel driver Guido Günther

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190325161030.GA30679@bogon.m.sigxcpu.org \
    --to=agx@sigxcpu.org \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=festevam@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®