mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org, Michal Kubecek <mkubecek@suse.cz>
Subject: Re: [PATCH] parport: daisy: do not try to load lowlevel driver
Date: Mon, 25 Mar 2019 17:53:38 -0400	[thread overview]
Message-ID: <20190325175338.2fa290cc@gandalf.local.home> (raw)
In-Reply-To: <20190325211325.21411-1-sudipm.mukherjee@gmail.com>

On Mon, 25 Mar 2019 21:13:25 +0000
Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:

> Some distros like Suse has an alias for "parport_lowlevel" and that
> alias points to "parport_pc". Now when the parport bus registers, it
> also initialises the daisy driver as the daisy driver is needed to
> check the port when the port is first found. Due to the new device
> model daisy driver will now try to find the parallel ports while trying
> to register its driver so that it can bind with them. Now, since daisy
> driver is loaded while parport bus is initialising the list of parport
> is still empty and it tries to load the lowlevel driver, which has an
> alias set to parport_pc, now causes a deadlock.
> 
> We do not need to search for ports and bind the initial list of ports
> to daisy driver as daisy driver is always the first driver to use the
> new found parport and we know when the parport bus is registering the
> list of parport will always be empty. So, proceed with the daisy_drv
> registration even if the list of parport is empty.
> 
> Fixes: 1aec4211204d ("parport: daisy: use new parport device model")
> Reported-by: Michal Kubecek <mkubecek@suse.cz>
> Reported-by: Steven Rostedt <rostedt@goodmis.org>
> Tested-by: Michal Kubecek <mkubecek@suse.cz>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>

Tested-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve

      parent reply	other threads:[~2019-03-25 21:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-25 21:13 Sudip Mukherjee
2019-03-25 21:48 ` Linus Torvalds
2019-03-25 22:34   ` Sudip Mukherjee
2019-03-25 21:53 ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190325175338.2fa290cc@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkubecek@suse.cz \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®