From: David Miller <davem@davemloft.net>
To: Mario.Limonciello@dell.com
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, hayeswang@realtek.com,
sjg@google.com, campello@google.com, Ryan.Hong@Dell.com,
Crag.Wang@dell.com
Subject: Re: [PATCH] r8152: Refresh MAC address during USBDEVFS_RESET
Date: Tue, 26 Mar 2019 13:23:01 -0700 (PDT) [thread overview]
Message-ID: <20190326.132301.1327548456879111686.davem@davemloft.net> (raw)
In-Reply-To: <f1d2f070fd124fe3bc83a7d6535a61ef@ausx13mpc120.AMER.DELL.COM>
From: <Mario.Limonciello@dell.com>
Date: Tue, 26 Mar 2019 19:52:50 +0000
>> -----Original Message-----
>> From: David Miller <davem@davemloft.net>
>> Sent: Tuesday, March 26, 2019 1:51 PM
>> To: Limonciello, Mario
>> Cc: linux-usb@vger.kernel.org; netdev@vger.kernel.org; linux-
>> kernel@vger.kernel.org; hayeswang@realtek.com; sjg@google.com;
>> campello@google.com; Hong, Ryan; Wang, Crag
>> Subject: Re: [PATCH] r8152: Refresh MAC address during USBDEVFS_RESET
>>
>>
>> [EXTERNAL EMAIL]
>>
>> From: Mario Limonciello <mario.limonciello@dell.com>
>> Date: Mon, 25 Mar 2019 09:12:23 -0500
>>
>> > On some platforms it is possible to dynamically change the policy
>> > of what MAC address is selected from the ASL at runtime.
>> >
>> > These tools will reset the USB device and expect the change to be
>> > made immediately.
>> >
>> > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
>>
>> You are going to have to emit CHANGEADDR notifications and such if
>> necessary when you do this.
>
> Thanks for the feedback, I'll add that call. Do you feel a need that the MAC
> address needs to be tracked and compared to what was previously in ACPI
> table to know it "really" changed or just emit CHANGEADDR because it "might"
> have changed?
Probably it is better for apps to track it.
You can consider using dev_set_mac_address(), I wouldn't advise cooking your
own copy of the event emission code.
prev parent reply other threads:[~2019-03-26 20:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 14:12 Mario Limonciello
2019-03-25 18:02 ` Simon Glass
2019-03-26 18:50 ` David Miller
2019-03-26 19:52 ` Mario.Limonciello
2019-03-26 20:23 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190326.132301.1327548456879111686.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Crag.Wang@dell.com \
--cc=Mario.Limonciello@dell.com \
--cc=Ryan.Hong@Dell.com \
--cc=campello@google.com \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sjg@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®