mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Ronald Tschalär" <ronald@innovation.ch>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Henrik Rydberg" <rydberg@bitmath.org>,
	"Sergey Senozhatsky" <sergey.senozhatsky@gmail.com>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Lukas Wunner" <lukas@wunner.de>,
	"Federico Lorenzi" <federico@travelground.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] Input: add Apple SPI keyboard and trackpad driver.
Date: Wed, 27 Mar 2019 19:45:26 +0100	[thread overview]
Message-ID: <20190327184526.GA11095@kroah.com> (raw)
In-Reply-To: <20190327093530.GH9224@smile.fi.intel.com>

On Wed, Mar 27, 2019 at 11:35:30AM +0200, Andy Shevchenko wrote:
> On Tue, Mar 26, 2019 at 06:48:07PM -0700, Ronald Tschalär wrote:
> > The keyboard and trackpad on recent MacBook's (since 8,1) and
> > MacBookPro's (13,* and 14,*) are attached to an SPI controller instead
> > of USB, as previously. The higher level protocol is not publicly
> > documented and hence has been reverse engineered. As a consequence there
> > are still a number of unknown fields and commands. However, the known
> > parts have been working well and received extensive testing and use.
> > 
> > In order for this driver to work, the proper SPI drivers need to be
> > loaded too; for MB8,1 these are spi_pxa2xx_platform and spi_pxa2xx_pci;
> > for all others they are spi_pxa2xx_platform and intel_lpss_pci. For this
> > reason enabling this driver in the config implies enabling the above
> > drivers.
> 
> > +// SPDX-License-Identifier: GPL-2.0
> 
> According to last changes this should be GPL-2.0-only

What "last changes"?  "GPL-2.0" is a totally valid SPDX identifier for
the kernel.  Don't buy into the "-only" prefix crud that the newer SPDX
version adopted for crazy reasons.  The in-kernel documentation lists
the valid identifiers and the version of SPDX we are currently using.

thanks,

greg k-h

  reply	other threads:[~2019-03-27 18:45 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-27  1:48 [PATCH v3 0/4] Add " Ronald Tschalär
2019-03-27  1:48 ` [PATCH v3 1/4] drm/bridge: sil_sii8620: depend on INPUT instead of selecting it Ronald Tschalär
2019-03-27 14:13   ` Andrzej Hajda
2019-03-28  0:07     ` Life is hard, and then you die
2019-03-28 11:48       ` Andrzej Hajda
2019-03-29  9:22         ` Life is hard, and then you die
2019-03-27  1:48 ` [PATCH v3 2/4] lib/hexdump.c: factor out generic hexdump formatting for reuse Ronald Tschalär
2019-03-27  7:46   ` Andy Shevchenko
2019-03-28  0:34     ` Life is hard, and then you die
2019-03-28  9:03       ` Andy Shevchenko
2019-03-28 10:29         ` Life is hard, and then you die
2019-03-27  1:48 ` [PATCH v3 3/4] driver core: add dev_print_hex_dump() logging function Ronald Tschalär
2019-03-27  2:37   ` Greg Kroah-Hartman
2019-03-28  0:28     ` Life is hard, and then you die
2019-03-28  5:29       ` Greg Kroah-Hartman
2019-03-28 10:27         ` Life is hard, and then you die
2019-03-28 11:29           ` Greg Kroah-Hartman
2019-03-28 12:30             ` Steven Rostedt
2019-04-02  2:47             ` Life is hard, and then you die
2019-04-02  6:33               ` Greg Kroah-Hartman
2019-04-07  1:46                 ` Life is hard, and then you die
2019-04-08 12:07                   ` Andy Shevchenko
2019-03-27  1:48 ` [PATCH v3 4/4] Input: add Apple SPI keyboard and trackpad driver Ronald Tschalär
2019-03-27  9:35   ` Andy Shevchenko
2019-03-27 18:45     ` Greg Kroah-Hartman [this message]
2019-03-27 19:15       ` Steven Rostedt
2019-03-27 19:22       ` Andy Shevchenko
2019-03-28  0:24     ` Life is hard, and then you die

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190327184526.GA11095@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=federico@travelground.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=rafael@kernel.org \
    --cc=ronald@innovation.ch \
    --cc=rostedt@goodmis.org \
    --cc=rydberg@bitmath.org \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome