From: Steven Rostedt <rostedt@goodmis.org>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Cc: David Abdurachmanov <david.abdurachmanov@gmail.com>,
Will Drewry <wad@chromium.org>, Kees Cook <keescook@chromium.org>,
Palmer Dabbelt <palmer@sifive.com>,
linux-kernel@vger.kernel.org,
Andy Lutomirski <luto@amacapital.net>,
Ingo Molnar <mingo@redhat.com>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH] riscv: fix syscall_get_arguments() and syscall_set_arguments()
Date: Fri, 29 Mar 2019 16:32:08 -0400 [thread overview]
Message-ID: <20190329163208.73f6d9fa@gandalf.local.home> (raw)
In-Reply-To: <20190329181109.GA32651@altlinux.org>
On Fri, 29 Mar 2019 21:11:09 +0300
"Dmitry V. Levin" <ldv@altlinux.org> wrote:
> On Fri, Mar 29, 2019 at 01:56:35PM -0400, Steven Rostedt wrote:
> > On Fri, 29 Mar 2019 18:52:18 +0100
> > David Abdurachmanov <david.abdurachmanov@gmail.com> wrote:
> >
> > > I have alternative version posted in December part of SECCOMP
> > > patchset which is based on arm64 implementation.
> > >
> > > http://lists.infradead.org/pipermail/linux-riscv/2018-December/002450.html
> > >
> > > I noticed that SECCOMP wasn't working properly if filters were
> > > checking syscall arguments, because populated arguments were wrong.
> > >
> > > Btw, I plan to send v2 of SECCOMP patchset soonish.
> >
> > Please do. I want to get my patch series out, which will require these
> > changes.
>
> Sorry, I haven't seen the alternative patch posted by David before.
> Apparently, besides fixing the bug it also introduces new sanity checks
> of "i" and "n" arguments in syscall_get_arguments() and
> syscall_set_arguments().
>
> Given that your patchset removes these arguments completely,
> I see little sense in adding new checks that are going to be removed
> by the subsequent commit in the series.
I agree. I'm going to pull in Dmitry's patches as my patches are going
to rewrite most the code anyway, and no need for the extra churn of the
sanity checks that are going to become irrelevant immediately afterward.
-- Steve
next prev parent reply other threads:[~2019-03-29 20:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 17:12 Dmitry V. Levin
2019-03-29 17:15 ` Steven Rostedt
2019-03-29 17:52 ` David Abdurachmanov
2019-03-29 17:56 ` Steven Rostedt
2019-03-29 18:11 ` Dmitry V. Levin
2019-03-29 20:32 ` Steven Rostedt [this message]
2019-03-29 18:16 ` Dmitry V. Levin
2019-03-29 20:33 ` Steven Rostedt
2019-03-30 0:26 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190329163208.73f6d9fa@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=david.abdurachmanov@gmail.com \
--cc=keescook@chromium.org \
--cc=ldv@altlinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=palmer@sifive.com \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®