From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0305C43381 for ; Sat, 30 Mar 2019 00:55:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 78E2C2064A for ; Sat, 30 Mar 2019 00:55:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553907301; bh=mieKSJEfBr4UGF73KWHdr8dHsybl2THj4umMleaES8s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=qSEZSOKIEACI7ITN5Qn9q7d0DtGOoujQ3QZWvvo/gTi9kKwAE72x0CKNcuGvLvhBO UsW/wbZnrU5wP+65yAkU6LSg+88R7X/bHYjXYGVNAJnDRfDewFhadURc9mGUEghvcj B7JNlOOc/GNfVB6rnwuUHdlMJKc/pV6y6VRYt2Qg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731660AbfC3AzA (ORCPT ); Fri, 29 Mar 2019 20:55:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:34002 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731633AbfC3Ayy (ORCPT ); Fri, 29 Mar 2019 20:54:54 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 13E7E2064A; Sat, 30 Mar 2019 00:54:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553907293; bh=mieKSJEfBr4UGF73KWHdr8dHsybl2THj4umMleaES8s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KzjoRN/eBxAODkTFE2fFRSLh2clbpxacZH/MG9WoJV+zdJvc0x7/1z+RF70vGLJTP bx2mDGq0wzZGeVbos+71BXaGff1juApdgmNmXue3phpR6qtXKX03hEm1y43H9MD/S2 0EHxDv0lgiqFb2aXMSb27ijnvGsGlhRMWok2LmWM= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Andy Shevchenko , Miguel Ojeda , Sasha Levin Subject: [PATCH AUTOSEL 4.14 08/37] auxdisplay: hd44780: Fix memory leak on ->remove() Date: Fri, 29 Mar 2019 20:54:09 -0400 Message-Id: <20190330005441.27540-8-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190330005441.27540-1-sashal@kernel.org> References: <20190330005441.27540-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andy Shevchenko [ Upstream commit 41c8d0adf3c4df1867d98cee4a2c4531352a33ad ] We have to free on ->remove() the allocated resources on ->probe(). Fixes: d47d88361fee ("auxdisplay: Add HD44780 Character LCD support") Reviewed-by: Geert Uytterhoeven Signed-off-by: Andy Shevchenko Signed-off-by: Miguel Ojeda Signed-off-by: Sasha Levin --- drivers/auxdisplay/hd44780.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/auxdisplay/hd44780.c b/drivers/auxdisplay/hd44780.c index 036eec404289..2d927feb3db4 100644 --- a/drivers/auxdisplay/hd44780.c +++ b/drivers/auxdisplay/hd44780.c @@ -302,6 +302,8 @@ static int hd44780_remove(struct platform_device *pdev) struct charlcd *lcd = platform_get_drvdata(pdev); charlcd_unregister(lcd); + + kfree(lcd); return 0; } -- 2.19.1