From: Mark Brown <broonie@kernel.org>
To: tony.zou.hq@gmail.com
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com, linux-kernel@vger.kernel.org,
dbasehore@chromium.org,
Tony Zou <zoutao@huaqin.corp-partner.google.com>
Subject: Re: [PATCH] max98357a:add dai without triggered by pcm
Date: Mon, 1 Apr 2019 10:24:46 +0700 [thread overview]
Message-ID: <20190401032446.GC2059@sirena.org.uk> (raw)
In-Reply-To: <1553824319-2155-1-git-send-email-tony.zou.hq@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 611 bytes --]
On Fri, Mar 29, 2019 at 09:51:59AM +0800, tony.zou.hq@gmail.com wrote:
> max98357a's enable pin need setting independently
> when max98357a is shared I2S with other codec.
> add dai "max98357a-hifi" without pcm trigger,
> and use "Spk PA Switch" to set the enable pin.
This sounds like a really bad idea - if you have multiple CODECs on a
single DAI link tell the core about it, don't try to bodge around it.
There's support for multiple CODECs on a DAI link already.
> +static const char * const ext_spk_text[] = {
> + "Off", "On"
> +};
Simple on/off switches should be normal switch controls, not enums.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-04-01 3:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 1:51 tony.zou.hq
2019-04-01 3:24 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401032446.GC2059@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=dbasehore@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tony.zou.hq@gmail.com \
--cc=zoutao@huaqin.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®