From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A9CDC43381 for ; Mon, 1 Apr 2019 08:22:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 377D12084B for ; Mon, 1 Apr 2019 08:22:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732004AbfDAIWr (ORCPT ); Mon, 1 Apr 2019 04:22:47 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:53865 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725867AbfDAIWq (ORCPT ); Mon, 1 Apr 2019 04:22:46 -0400 X-Originating-IP: 90.88.32.136 Received: from localhost (aaubervilliers-681-1-91-136.w90-88.abo.wanadoo.fr [90.88.32.136]) (Authenticated sender: maxime.ripard@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 35478E000A; Mon, 1 Apr 2019 08:22:42 +0000 (UTC) Date: Mon, 1 Apr 2019 10:22:42 +0200 From: Maxime Ripard To: megous@megous.com Cc: Chen-Yu Tsai , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-sunxi@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] ARM: dts: sun8i: a83t: Add missing CPU clock references Message-ID: <20190401082242.ashnencaiubbidor@flea> References: <20190328113159.9668-1-megous@megous.com> <20190328113159.9668-3-megous@megous.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="grs2naoclmftaqc6" Content-Disposition: inline In-Reply-To: <20190328113159.9668-3-megous@megous.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --grs2naoclmftaqc6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, On Thu, Mar 28, 2019 at 12:31:59PM +0100, megous@megous.com wrote: > From: Ondrej Jirman > > A83T DTSI has cpu clocks defined only on the first CPU in each cluster. > We can bring down any CPU in the cluster, so we need to define clock > for each CPU, so that the system knows what clock to use if the first > CPU is down. > > Signed-off-by: Ondrej Jirman > --- > arch/arm/boot/dts/sun8i-a83t.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > index 7a40b7d77ec0..1b0b025b9250 100644 > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > @@ -73,6 +73,8 @@ > }; > > cpu@1 { > + clocks = <&ccu CLK_C0CPUX>; Usually we'll have the compatible first > + clock-names = "cpu"; And that's not documented anywhere? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --grs2naoclmftaqc6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXKHKUgAKCRDj7w1vZxhR xVo+AP4/zhT0wyZ9KFGLkkgq2yY7C4naWfUB1XvjjQogr2wHJwD+IYXdMqEqQqxy nzvVVxBKBxCYF7BNrwIXedTaMFPwgwg= =qu8m -----END PGP SIGNATURE----- --grs2naoclmftaqc6--