From: Catalin Marinas <catalin.marinas@arm.com>
To: Muchun Song <smuchun@gmail.com>
Cc: will.deacon@arm.com, akpm@linux-foundation.org,
rppt@linux.vnet.ibm.com,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Florian Fainelli <f.fainelli@gmail.com>,
logang@deltatee.com, robin.murphy@arm.com, ghackmann@android.com,
hannes@cmpxchg.org, stefan@agner.ch, david@redhat.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: mm: fix max_mapnr is assigned the wrong value
Date: Mon, 1 Apr 2019 15:32:41 +0100 [thread overview]
Message-ID: <20190401143241.GH14874@arrakis.emea.arm.com> (raw)
In-Reply-To: <CAPSr9jHmx8unVN3rsQzGSSc4hYL2wafw20D8QKf8NG65dX7ErQ@mail.gmail.com>
On Mon, Apr 01, 2019 at 10:21:58PM +0800, Muchun Song wrote:
> Thanks for your reply. In fact, I didn't hit any problem. I just read the code
> and found the problem. I see max_mapnr is to only be used in the
> generic pfn_valid().
> As you said, we do not use it on arm64. So in a sense, the patch is
> meaningless.
>
> But I think since it is a problem, why not fix it (Even if max_mapnr
> is not be used)?
> What is your opinion?
I'm ok with fixing, only that it's not urgent. Will can pick it up for
the 5.2 merging window.
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
prev parent reply other threads:[~2019-04-01 14:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-30 13:13 Muchun Song
2019-04-01 10:44 ` Catalin Marinas
2019-04-01 14:21 ` Muchun Song
2019-04-01 14:32 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401143241.GH14874@arrakis.emea.arm.com \
--to=catalin.marinas@arm.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=david@redhat.com \
--cc=f.fainelli@gmail.com \
--cc=ghackmann@android.com \
--cc=hannes@cmpxchg.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=robin.murphy@arm.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=smuchun@gmail.com \
--cc=stefan@agner.ch \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®