mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon@arm.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: vdso: fix and clean-up Makefile
Date: Wed, 3 Apr 2019 18:08:18 +0100	[thread overview]
Message-ID: <20190403170818.GC17500@fuggles.cambridge.arm.com> (raw)
In-Reply-To: <CAK7LNAQ4aabQoMwWZNUEACPC3_SQPdmq+5cAOQD-d+yvXE7Qzg@mail.gmail.com>

On Thu, Apr 04, 2019 at 02:04:23AM +0900, Masahiro Yamada wrote:
> On Wed, Apr 3, 2019 at 9:45 PM Will Deacon <will.deacon@arm.com> wrote:
> > On Wed, Apr 03, 2019 at 05:48:22PM +0900, Masahiro Yamada wrote:
> > > - $(call if_changed,...) must have FORCE as a prerequisite
> > >
> > > - vdso.lds is a generated file, so it should be prefixed with
> > >   $(obj)/ instead of $(src)/.
> >
> > Hmm, this sounds quite alarming! How come out of tree builds seem to work
> > ok without this patch?
> 
> No, I do not mean like that.
> This is just cosmetic (at least for now).
> Kbuild conventionally use both $(obj) and $(src), but
> they are the same in most places.
> If you see the top of scripts/Makefile.build,
> $(src) is the same as $(obj).

Ah thanks, that makes much more sense. I'll queue this up for 5.2.

Will

      reply	other threads:[~2019-04-03 17:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-03  8:48 Masahiro Yamada
2019-04-03 12:44 ` Will Deacon
2019-04-03 17:04   ` Masahiro Yamada
2019-04-03 17:08     ` Will Deacon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190403170818.GC17500@fuggles.cambridge.arm.com \
    --to=will.deacon@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®