From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0DE5C4360F for ; Thu, 4 Apr 2019 02:09:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 742F520820 for ; Thu, 4 Apr 2019 02:09:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=sent.com header.i=@sent.com header.b="ZTcljXgK"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="FQOkb9gU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726672AbfDDCJs (ORCPT ); Wed, 3 Apr 2019 22:09:48 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:59387 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726427AbfDDCJp (ORCPT ); Wed, 3 Apr 2019 22:09:45 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id B644522AB8; Wed, 3 Apr 2019 22:01:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 03 Apr 2019 22:01:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sent.com; h=from :to:cc:subject:date:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; s=fm3; bh=90OfIYrsLVV/X L3gUGgucTsSXTyMHPlo/8YAawvSo30=; b=ZTcljXgKyrhIcGFZqw0NEMiVpsJTj WIedhk8FmwdAwNdcO/lmKhbASK3zQyp8yrVxgQiD9s80HAVdqAxKpAXfrUwQgwDS HgjyFJJtczMeURxtFvM3M5d9ca37WW0IaGa+7sRAGhTZBv+q1lOX2o7q8mzaWX5y /wc/XLxzzCJtsPDZUaf+ZX5sulfsDLUVeQAOMAB1GROLM370bU+EU5LVZ2Or6n0Y a5PK3Zx9vxs3sgzGvieVLHnMK57yuhLB3QuzYX8XxPpsLxGFvAmwg7YYsCBPFUcQ vR/sZSU4THIU844zmdtAJMJ27ZujmNsbFVEvUkqlq8rhZZhksVXBf/SSQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:reply-to:subject :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=90OfIYrsLVV/XL3gUGgucTsSXTyMHPlo/8YAawvSo30=; b=FQOkb9gU Wkt8yUg1JLS3hUvT+MWCzBfCq1LO4fDjtBiCZmKlCrIXPv9WDGmMQQTncX5wHiI0 DSYBHbRosU5Mu8R+OPCgLMc5VDnC9PiMahmjzc+tNFdNQw8tPpvof+UMuCFZ3A8V Gkk3N7WpIe1eJ7y6oljn0705l7NXHq1RE/rm8Y7oFB3Xqod0Q9liAKUeVmQ/I38H /KybQVLISD/6fmLiBCGgLOy2OyLz7GQwlGiSyBHJJSterSdu4vFe1iZSrjwzJrkf hZVH+e71873++cIHWH9Gp+0SNUk4PquC3YQfZ37jddtruYC4WXKR1MpK8Vg/ICUJ 9Xrbp/lZmiGkjw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtdeggdehudculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkofgjfhhrggfgsedtkeertdertddt necuhfhrohhmpegkihcujggrnhcuoeiiihdrhigrnhesshgvnhhtrdgtohhmqeenucfkph epvdduiedrvddvkedrudduvddrvddvnecurfgrrhgrmhepmhgrihhlfhhrohhmpeiiihdr higrnhesshgvnhhtrdgtohhmnecuvehluhhsthgvrhfuihiivgepudej X-ME-Proxy: Received: from nvrsysarch5.nvidia.com (thunderhill.nvidia.com [216.228.112.22]) by mail.messagingengine.com (Postfix) with ESMTPA id C4EE61030F; Wed, 3 Apr 2019 22:01:48 -0400 (EDT) From: Zi Yan To: Dave Hansen , Yang Shi , Keith Busch , Fengguang Wu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Daniel Jordan , Michal Hocko , "Kirill A . Shutemov" , Andrew Morton , Vlastimil Babka , Mel Gorman , John Hubbard , Mark Hairgrove , Nitin Gupta , Javier Cabezas , David Nellans , Zi Yan Subject: [RFC PATCH 21/25] mm: move update_lru_sizes() to mm_inline.h for broader use. Date: Wed, 3 Apr 2019 19:00:42 -0700 Message-Id: <20190404020046.32741-22-zi.yan@sent.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190404020046.32741-1-zi.yan@sent.com> References: <20190404020046.32741-1-zi.yan@sent.com> Reply-To: ziy@nvidia.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zi Yan Signed-off-by: Zi Yan --- include/linux/mm_inline.h | 21 +++++++++++++++++++++ mm/vmscan.c | 25 ++----------------------- 2 files changed, 23 insertions(+), 23 deletions(-) diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h index 04ec454..b9fbd0b 100644 --- a/include/linux/mm_inline.h +++ b/include/linux/mm_inline.h @@ -44,6 +44,27 @@ static __always_inline void update_lru_size(struct lruvec *lruvec, #endif } +/* + * Update LRU sizes after isolating pages. The LRU size updates must + * be complete before mem_cgroup_update_lru_size due to a santity check. + */ +static __always_inline void update_lru_sizes(struct lruvec *lruvec, + enum lru_list lru, unsigned long *nr_zone_taken) +{ + int zid; + + for (zid = 0; zid < MAX_NR_ZONES; zid++) { + if (!nr_zone_taken[zid]) + continue; + + __update_lru_size(lruvec, lru, zid, -nr_zone_taken[zid]); +#ifdef CONFIG_MEMCG + mem_cgroup_update_lru_size(lruvec, lru, zid, -nr_zone_taken[zid]); +#endif + } + +} + static __always_inline void add_page_to_lru_list(struct page *page, struct lruvec *lruvec, enum lru_list lru) { diff --git a/mm/vmscan.c b/mm/vmscan.c index a5ad0b3..1d539d6 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1593,27 +1593,6 @@ int __isolate_lru_page(struct page *page, isolate_mode_t mode) } -/* - * Update LRU sizes after isolating pages. The LRU size updates must - * be complete before mem_cgroup_update_lru_size due to a santity check. - */ -static __always_inline void update_lru_sizes(struct lruvec *lruvec, - enum lru_list lru, unsigned long *nr_zone_taken) -{ - int zid; - - for (zid = 0; zid < MAX_NR_ZONES; zid++) { - if (!nr_zone_taken[zid]) - continue; - - __update_lru_size(lruvec, lru, zid, -nr_zone_taken[zid]); -#ifdef CONFIG_MEMCG - mem_cgroup_update_lru_size(lruvec, lru, zid, -nr_zone_taken[zid]); -#endif - } - -} - /** * pgdat->lru_lock is heavily contended. Some of the functions that * shrink the lists perform better by taking out a batch of pages @@ -1804,7 +1783,7 @@ static int too_many_isolated(struct pglist_data *pgdat, int file, return isolated > inactive; } -static noinline_for_stack void +noinline_for_stack void putback_inactive_pages(struct lruvec *lruvec, struct list_head *page_list) { struct zone_reclaim_stat *reclaim_stat = &lruvec->reclaim_stat; @@ -2003,7 +1982,7 @@ shrink_inactive_list(unsigned long nr_to_scan, struct lruvec *lruvec, * Returns the number of pages moved to the given lru. */ -static unsigned move_active_pages_to_lru(struct lruvec *lruvec, +unsigned move_active_pages_to_lru(struct lruvec *lruvec, struct list_head *list, struct list_head *pages_to_free, enum lru_list lru) -- 2.7.4