From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4169C4360F for ; Thu, 4 Apr 2019 02:52:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D5062133D for ; Thu, 4 Apr 2019 02:52:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726462AbfDDCwo (ORCPT ); Wed, 3 Apr 2019 22:52:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33952 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726218AbfDDCwn (ORCPT ); Wed, 3 Apr 2019 22:52:43 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 987F081E10; Thu, 4 Apr 2019 02:52:43 +0000 (UTC) Received: from dhcp-128-65.nay.redhat.com (ovpn-12-97.pek2.redhat.com [10.72.12.97]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 20B8E6B2D8; Thu, 4 Apr 2019 02:52:39 +0000 (UTC) Date: Thu, 4 Apr 2019 10:52:34 +0800 From: Dave Young To: Junichi Nomura Cc: Chao Fan , Borislav Petkov , "bhe@redhat.com" , "kasong@redhat.com" , "x86@kernel.org" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel Message-ID: <20190404025234.GA12658@dhcp-128-65.nay.redhat.com> References: <20190328155256.GP22720@zn.tnic> <20190401000837.GA5170@jeru.linux.bs1.fc.nec.co.jp> <20190402120319.GA7605@dhcp-128-65.nay.redhat.com> <20190403053459.GD1555@localhost.localdomain> <20190403055340.GA11976@dhcp-128-65.nay.redhat.com> <20190403072141.GE1555@localhost.localdomain> <20190403080846.GB2579@dhcp-128-65.nay.redhat.com> <20190403082305.GG1555@localhost.localdomain> <20190403090210.GH1555@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 04 Apr 2019 02:52:43 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/04/19 at 01:23am, Junichi Nomura wrote: > Hi Dave and Chao, > > On 4/3/19 6:02 PM, Chao Fan wrote: > > On Wed, Apr 03, 2019 at 04:23:06PM +0800, Chao Fan wrote: > >> On Wed, Apr 03, 2019 at 04:09:16PM +0800, Dave Young wrote: > >>> Fix 3. need more debugging, have you or Junichi run tests on more real > >>> hardware, maybe it is easier to reproduce on real hardware, I'm glad to > >>> help to try test patch or provide any help. > >> > >> I am still testing in real hardware. > > > > Hi Dave, > > > > I find a Fujitsu Desktop PC to test it. > > Without this PATCH, it failed to kexec and kdump. > > With this PATCH, it succeed to kexec. > > But failed to kdump. From the log, I think it didn't jump to the second > > kernel, just reboot after panic. I have not figured out what's the > > problem, but it seems not caused by this PATCH. > > So I still think this PATCH works for the Fujitsu Desktop PC. > > > > As for your issue, I think there may be some problems related to specified > > hardware. Are you using a Lenovo laptop? > > > > And I am not sure how Nomura tested it. > > I've tested 3 different models of EFI-booted baremetal servers with both > normal kexec and panic kexec. So far as I've tried Linus's v5.1-rc3, > the problem always reproduced without the patch and disappears with the patch. Hmm, both of my two laptops (Thinkpad T480s and T420) failed to boot with kexec. I will see if I can find something, but it may need more time because early console does not work especially after kexec. Thanks Dave