From: David Miller <davem@davemloft.net>
To: linmiaohe@huawei.com
Cc: dsa@cumulusnetworks.com, shrijeet@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
mingfangsen@huawei.com
Subject: Re: [PATCH net] net: vrf: Fix ping failed when vrf mtu is set to 0
Date: Sat, 06 Apr 2019 18:12:32 -0700 (PDT) [thread overview]
Message-ID: <20190406.181232.473436529978209156.davem@davemloft.net> (raw)
In-Reply-To: <0da12059-229f-e167-ad41-14b56993a029@huawei.com>
From: linmiaohe <linmiaohe@huawei.com>
Date: Thu, 4 Apr 2019 20:01:13 +0800
> From: Miaohe Lin <linmiaohe@huawei.com>
>
> When the mtu of a vrf device is set to 0, it would cause ping
> failed.So I think we should limit dev->min_mtu to ETH_MIN_MTU
> to solve this problem. And if dev->max_mtu still be 0 can be
> confusing, so I limit dev->max_mtu to ETH_MAX_MTU.
>
> Here is the reproduce step:
Just in case it isn't clear, David Ahern gave you feedback and
asked you to adjust things so that the problem is solved for ipv6
as well. He also gave you an appropriate Fixes: tag to add to
your commit message.
next prev parent reply other threads:[~2019-04-07 1:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 12:01 linmiaohe
2019-04-04 17:52 ` David Miller
2019-04-04 18:05 ` David Ahern
2019-04-07 1:12 ` David Miller [this message]
2019-04-07 2:29 ` linmiaohe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190406.181232.473436529978209156.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingfangsen@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=shrijeet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®