From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90AC4C282CE for ; Mon, 8 Apr 2019 07:33:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E53F20870 for ; Mon, 8 Apr 2019 07:33:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554708788; bh=oB3ZA3grj2eQgQKkflDvu0R0EZc6Q6XffLWEo4mZu/s=; h=From:To:Cc:Subject:In-Reply-To:Date:List-ID:From; b=gWSNhTOEQc5ql6HAL3pGfWWdgA/0qNai/yGFeO9jFvE+6X54WO+aMQELO3ZiLDlTQ I0wUUvDDfGYryIk0Vx2ilbjvV3LZ2CSXvQroFzmKxObpWccPtpE20I5IcOarWnFV4c IAoYRjaaskGOVTRpROER/6TbeIhbX9oOCyYqMjz4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726640AbfDHHdG (ORCPT ); Mon, 8 Apr 2019 03:33:06 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:45528 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726240AbfDHHdG (ORCPT ); Mon, 8 Apr 2019 03:33:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=lJiu/8K1CwNpnXq+nV6CsEuCn1vgrNfutreOCSlcCxA=; b=T3XEtuSHp0MQ HrVGNBW1zjvJRDRo8xNKeSGSZCsoD9cZy9CziqdLubtB8IXwkvLMeM/hojoDOdlmQc4JC9iqq0HJm 19ClGVlqRIUZs7fhOtkeyi4Gvgr7RmHhGSepLRFUcrUSCUrDphLDmR7RjhJqLXcd15zANgQZDvpV1 T76Sg=; Received: from [8.46.76.46] (helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hDOlv-0003yo-AC; Mon, 08 Apr 2019 07:32:52 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id EEC2C441D3C; Mon, 8 Apr 2019 14:32:41 +0700 (+07) From: Mark Brown To: Flavio Suligoi Cc: Mark Brown , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Subject: Applied "spi: pxa2xxx: change "no DMA channels..." msg from debug to warning" to the spi tree In-Reply-To: <1554468022-17416-1-git-send-email-f.suligoi@asem.it> X-Patchwork-Hint: ignore Message-Id: <20190408073241.EEC2C441D3C@finisterre.ee.mobilebroadband> Date: Mon, 8 Apr 2019 14:32:41 +0700 (+07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch spi: pxa2xxx: change "no DMA channels..." msg from debug to warning has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 8b57b11bc45ee512566513259cd3c302df3c9dae Mon Sep 17 00:00:00 2001 From: Flavio Suligoi Date: Fri, 5 Apr 2019 14:40:22 +0200 Subject: [PATCH] spi: pxa2xxx: change "no DMA channels..." msg from debug to warning Change the type of the diagnostic message: "no DMA channels available, using PIO" from debug to warning. The lack of an available DMA channel is very important regard the spi-pxa2xx performance. The transfer speed can be reduced more than 50%. So it is very important to warn the user about this, without enabling the full SPI debug with CONFIG_SPI_DEBUG. Moreover, enabling the full SPI debug only to enable this specific debug message, the dmesg buffer fills quickly with a lot of repetitive information during the SPI data transfer. This cause the loss of all the first important messages written during the initialization. Signed-off-by: Flavio Suligoi Signed-off-by: Mark Brown --- drivers/spi/spi-pxa2xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index 6160fe0ce7ab..f7068ccfe7d2 100644 --- a/drivers/spi/spi-pxa2xx.c +++ b/drivers/spi/spi-pxa2xx.c @@ -1696,7 +1696,7 @@ static int pxa2xx_spi_probe(struct platform_device *pdev) if (platform_info->enable_dma) { status = pxa2xx_spi_dma_setup(drv_data); if (status) { - dev_dbg(dev, "no DMA channels available, using PIO\n"); + dev_warn(dev, "no DMA channels available, using PIO\n"); platform_info->enable_dma = false; } else { controller->can_dma = pxa2xx_spi_can_dma; -- 2.20.1