From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72087C10F13 for ; Mon, 8 Apr 2019 10:01:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 454BB208E3 for ; Mon, 8 Apr 2019 10:01:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726396AbfDHKBZ (ORCPT ); Mon, 8 Apr 2019 06:01:25 -0400 Received: from mga06.intel.com ([134.134.136.31]:58169 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725857AbfDHKBY (ORCPT ); Mon, 8 Apr 2019 06:01:24 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Apr 2019 03:01:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,324,1549958400"; d="scan'208";a="140887621" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by orsmga003.jf.intel.com with ESMTP; 08 Apr 2019 03:01:22 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1hDR5d-0006Zu-32; Mon, 08 Apr 2019 13:01:21 +0300 Date: Mon, 8 Apr 2019 13:01:21 +0300 From: Andy Shevchenko To: Jonathan Cameron Cc: Stephen Rothwell , Greg KH , Linux Next Mailing List , Linux Kernel Mailing List , Lars-Peter Clausen Subject: Re: linux-next: manual merge of the staging tree with the staging.current tree Message-ID: <20190408100121.GH9224@smile.fi.intel.com> References: <20190408130212.0a41f2a8@canb.auug.org.au> <20190408091458.00004e48@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190408091458.00004e48@huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 08, 2019 at 09:14:58AM +0100, Jonathan Cameron wrote: > On Mon, 8 Apr 2019 13:02:12 +1000 > Stephen Rothwell wrote: > > > Hi all, > > > > Today's linux-next merge of the staging tree got a conflict in: > > > > drivers/iio/industrialio-buffer.c > > > > between commit: > > > > 20ea39ef9f2f ("iio: Fix scan mask selection") > > > > from the staging.current tree and commit: > > > > 3862828a903d ("iio: buffer: Switch to bitmap_zalloc()") > > > > from the staging tree. > > > > I fixed it up (I just used the staging tree version) and can carry the > > fix as necessary. This is now fixed as far as linux-next is concerned, > > but any non trivial conflicts should be mentioned to your upstream > > maintainer when your tree is submitted for merging. You may also want > > to consider cooperating with the maintainer of the conflicting tree to > > minimise any particularly complex conflicts. > > > Thanks Stephen, > > That is the correct resolution. I think it still misses the following fix: diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c index 3c7e7380d1c3..9c2d0c97ed24 100644 --- a/drivers/iio/industrialio-buffer.c +++ b/drivers/iio/industrialio-buffer.c @@ -320,7 +320,7 @@ static int iio_scan_mask_set(struct iio_dev *indio_dev, const unsigned long *mask; unsigned long *trialmask; - trialmask = bitmap_alloc(indio_dev->masklength, GFP_KERNEL); + trialmask = bitmap_zalloc(indio_dev->masklength, GFP_KERNEL); if (trialmask == NULL) return -ENOMEM; if (!indio_dev->masklength) { -- With Best Regards, Andy Shevchenko